From ace90fd06e6538a5b75c1d0968adc04201ead940 Mon Sep 17 00:00:00 2001 From: Claude Date: Sat, 14 Nov 2026 13:21:47 +0000 Subject: [PATCH 1/2] Start hot-patch Windows test path fix Refs #2080 Assisted-by: Claude Code:claude-fable-5-2 Co-Authored-By: Claude Fable 5.2 Claude-Session: https://claude.ai/code/session_011f9aePVwfWQikf61EL6Ec7 From 5fffc73f8c68045853044f3ab44b073cfa069367 Mon Sep 17 00:00:00 2001 From: Claude Date: Sat, 14 Nov 2026 13:27:57 +0000 Subject: [PATCH 2/2] Compare hot-patch manifest paths as paths passes() builds each pass's manifest path with Path::join, which writes the platform's separator. The test compared the result to a /-joined string, so it failed on Windows and kept the scheduled main run red. Compare the two as paths instead: a / in a literal is a separator on every platform, so the expectation stays readable and holds on Windows too. Fixes #2080 Assisted-by: Claude Code:claude-fable-5-2 Co-Authored-By: Claude Fable 5.2 Claude-Session: https://claude.ai/code/session_011f9aePVwfWQikf61EL6Ec7 --- crates/socket-patch-cli/src/hot_patch.rs | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/crates/socket-patch-cli/src/hot_patch.rs b/crates/socket-patch-cli/src/hot_patch.rs index fd4ab0df7..d012d1099 100644 --- a/crates/socket-patch-cli/src/hot_patch.rs +++ b/crates/socket-patch-cli/src/hot_patch.rs @@ -619,14 +619,22 @@ mod tests { }; assert!(!project.common.global); assert_eq!(project.paths, ["packages/*"]); - assert_eq!(project.common.manifest_path, "/state/project/manifest.json"); + // Compared as paths: the separator `Path::join` writes is the + // platform's, and a `/` in a literal is one on every platform. + assert_eq!( + Path::new(&project.common.manifest_path), + Path::new("/state/project/manifest.json") + ); // Go is the global pass's: a project run would rewrite `go.mod`. assert!(!ecosystems(project).contains(&"golang")); assert!(ecosystems(project).contains(&"npm")); assert!(global.common.global); assert!(global.paths.is_empty()); assert_eq!(global.common.ecosystems, None); - assert_eq!(global.common.manifest_path, "/state/global/manifest.json"); + assert_eq!( + Path::new(&global.common.manifest_path), + Path::new("/state/global/manifest.json") + ); } #[test]