From e6e59cebf9231b770c46734a87a7af782a1d518b Mon Sep 17 00:00:00 2001 From: KhadeerBasha1232 Date: Thu, 19 Nov 2026 22:45:12 +0530 Subject: [PATCH] Pin third-party plugin scripts to exact versions Several plugins loaded JavaScript and CSS from CDN URLs without a fixed version (`@latest`, or jsDelivr/unpkg URLs with no version). The code in every generated map then changes whenever the upstream package or repo changes, including breaking releases or a compromised account. Pin each URL to the version it serves today: - GeoMan: @geoman-io/leaflet-geoman-free 2.20.8 - VectorGridProtobuf: leaflet.vectorgrid 1.3.0 - Geocoder: leaflet-control-geocoder 42.0.0 - TagFilterButton: leaflet-tag-filter-button 0.0.5 - DualMap: Leaflet.Sync 0.2.4 - BeautifyIcon, MousePosition: the current commit of their GitHub repos, which have no tags leaflet.boatmarker was unpublished from npm, so the unpkg URL now returns 404 and BoatMarker fails with "L.boatMarker is not a function". Load it from its GitHub repo instead, at the commit matching npm version 1.1.5. Co-Authored-By: Claude Opus 5.5 --- folium/plugins/beautify_icon.py | 4 ++-- folium/plugins/boat_marker.py | 2 +- folium/plugins/dual_map.py | 2 +- folium/plugins/geocoder.py | 4 ++-- folium/plugins/geoman.py | 4 ++-- folium/plugins/mouse_position.py | 4 ++-- folium/plugins/tag_filter_button.py | 4 ++-- folium/plugins/vectorgrid_protobuf.py | 2 +- tests/plugins/test_beautify_icon.py | 4 ++-- tests/plugins/test_boat_marker.py | 2 +- tests/plugins/test_dual_map.py | 2 +- tests/plugins/test_tag_filter_button.py | 4 ++-- 12 files changed, 19 insertions(+), 19 deletions(-) diff --git a/folium/plugins/beautify_icon.py b/folium/plugins/beautify_icon.py index 76d92517cc..baecca3320 100644 --- a/folium/plugins/beautify_icon.py +++ b/folium/plugins/beautify_icon.py @@ -73,13 +73,13 @@ class BeautifyIcon(JSCSSMixin, MacroElement): default_js = [ ( "beautify_icon_js", - "https://cdn.jsdelivr.net/gh/marslan390/BeautifyMarker/leaflet-beautify-marker-icon.min.js", + "https://cdn.jsdelivr.net/gh/marslan390/BeautifyMarker@55e0436a7fbbfc7d72dcad722a9b3058e0459f9d/leaflet-beautify-marker-icon.min.js", ) ] default_css = [ ( "beautify_icon_css", - "https://cdn.jsdelivr.net/gh/marslan390/BeautifyMarker/leaflet-beautify-marker-icon.min.css", + "https://cdn.jsdelivr.net/gh/marslan390/BeautifyMarker@55e0436a7fbbfc7d72dcad722a9b3058e0459f9d/leaflet-beautify-marker-icon.min.css", ) ] diff --git a/folium/plugins/boat_marker.py b/folium/plugins/boat_marker.py index 29e5c00e70..0af8116cc7 100644 --- a/folium/plugins/boat_marker.py +++ b/folium/plugins/boat_marker.py @@ -45,7 +45,7 @@ class BoatMarker(JSCSSMixin, Marker): default_js = [ ( "markerclusterjs", - "https://unpkg.com/leaflet.boatmarker/leaflet.boatmarker.min.js", + "https://cdn.jsdelivr.net/gh/thomasbrueggemann/leaflet.boatmarker@1193728f0626ae0cc55fbbd5912893446581332f/leaflet.boatmarker.min.js", ), ] diff --git a/folium/plugins/dual_map.py b/folium/plugins/dual_map.py index c410aaf994..7ba79a32ba 100644 --- a/folium/plugins/dual_map.py +++ b/folium/plugins/dual_map.py @@ -48,7 +48,7 @@ class DualMap(JSCSSMixin, MacroElement): default_js = [ ( "Leaflet.Sync", - "https://cdn.jsdelivr.net/gh/jieter/Leaflet.Sync/L.Map.Sync.min.js", + "https://cdn.jsdelivr.net/gh/jieter/Leaflet.Sync@0.2.4/L.Map.Sync.min.js", ) ] diff --git a/folium/plugins/geocoder.py b/folium/plugins/geocoder.py index 52ba060616..9dd674a80b 100644 --- a/folium/plugins/geocoder.py +++ b/folium/plugins/geocoder.py @@ -56,13 +56,13 @@ class Geocoder(JSCSSMixin, MacroElement): default_js = [ ( "Control.Geocoder.js", - "https://unpkg.com/leaflet-control-geocoder/dist/Control.Geocoder.js", + "https://unpkg.com/leaflet-control-geocoder@42.0.0/dist/Control.Geocoder.js", ) ] default_css = [ ( "Control.Geocoder.css", - "https://unpkg.com/leaflet-control-geocoder/dist/Control.Geocoder.css", + "https://unpkg.com/leaflet-control-geocoder@42.0.0/dist/Control.Geocoder.css", ) ] diff --git a/folium/plugins/geoman.py b/folium/plugins/geoman.py index 447a950507..f9b5f697f8 100644 --- a/folium/plugins/geoman.py +++ b/folium/plugins/geoman.py @@ -75,13 +75,13 @@ class GeoMan(JSCSSMixin, MacroElement): default_js = [ ( "leaflet_geoman_js", - "https://unpkg.com/@geoman-io/leaflet-geoman-free@latest/dist/leaflet-geoman.js", + "https://unpkg.com/@geoman-io/leaflet-geoman-free@2.20.8/dist/leaflet-geoman.js", ) ] default_css = [ ( "leaflet_geoman_css", - "https://unpkg.com/@geoman-io/leaflet-geoman-free@latest/dist/leaflet-geoman.css", + "https://unpkg.com/@geoman-io/leaflet-geoman-free@2.20.8/dist/leaflet-geoman.css", ) ] diff --git a/folium/plugins/mouse_position.py b/folium/plugins/mouse_position.py index cde9c51a82..7c5536891b 100644 --- a/folium/plugins/mouse_position.py +++ b/folium/plugins/mouse_position.py @@ -61,13 +61,13 @@ class MousePosition(JSCSSMixin, MacroElement): default_js = [ ( "Control_MousePosition_js", - "https://cdn.jsdelivr.net/gh/ardhi/Leaflet.MousePosition/src/L.Control.MousePosition.min.js", + "https://cdn.jsdelivr.net/gh/ardhi/Leaflet.MousePosition@c32f1c84ec49dbf7ad599c51c8659d5e08af0f97/src/L.Control.MousePosition.min.js", ) ] default_css = [ ( "Control_MousePosition_css", - "https://cdn.jsdelivr.net/gh/ardhi/Leaflet.MousePosition/src/L.Control.MousePosition.min.css", + "https://cdn.jsdelivr.net/gh/ardhi/Leaflet.MousePosition@c32f1c84ec49dbf7ad599c51c8659d5e08af0f97/src/L.Control.MousePosition.min.css", ) ] diff --git a/folium/plugins/tag_filter_button.py b/folium/plugins/tag_filter_button.py index 7291b17588..856a4ba79c 100644 --- a/folium/plugins/tag_filter_button.py +++ b/folium/plugins/tag_filter_button.py @@ -51,7 +51,7 @@ class TagFilterButton(JSCSSMixin, MacroElement): default_js = [ ( "tag-filter-button.js", - "https://cdn.jsdelivr.net/npm/leaflet-tag-filter-button/src/leaflet-tag-filter-button.js", + "https://cdn.jsdelivr.net/npm/leaflet-tag-filter-button@0.0.5/src/leaflet-tag-filter-button.js", ), ( "easy-button.js", @@ -61,7 +61,7 @@ class TagFilterButton(JSCSSMixin, MacroElement): default_css = [ ( "tag-filter-button.css", - "https://cdn.jsdelivr.net/npm/leaflet-tag-filter-button/src/leaflet-tag-filter-button.css", + "https://cdn.jsdelivr.net/npm/leaflet-tag-filter-button@0.0.5/src/leaflet-tag-filter-button.css", ), ( "easy-button.css", diff --git a/folium/plugins/vectorgrid_protobuf.py b/folium/plugins/vectorgrid_protobuf.py index 3438541a38..535d07a314 100644 --- a/folium/plugins/vectorgrid_protobuf.py +++ b/folium/plugins/vectorgrid_protobuf.py @@ -115,7 +115,7 @@ class VectorGridProtobuf(JSCSSMixin, Layer): default_js = [ ( "vectorGrid", - "https://unpkg.com/leaflet.vectorgrid@latest/dist/Leaflet.VectorGrid.bundled.js", + "https://unpkg.com/leaflet.vectorgrid@1.3.0/dist/Leaflet.VectorGrid.bundled.js", ) ] diff --git a/tests/plugins/test_beautify_icon.py b/tests/plugins/test_beautify_icon.py index 175c3a17b4..da49e9cdab 100644 --- a/tests/plugins/test_beautify_icon.py +++ b/tests/plugins/test_beautify_icon.py @@ -35,11 +35,11 @@ def test_beautify_icon(): out = normalize(m._parent.render()) # We verify that the script import is present. - script = '' # noqa + script = '' # noqa assert script in out # We verify that the css import is present. - css = '' # noqa + css = '' # noqa assert css in out # We verify that the Beautiful Icons are rendered correctly. diff --git a/tests/plugins/test_boat_marker.py b/tests/plugins/test_boat_marker.py index 906bec44f7..2b055399a9 100644 --- a/tests/plugins/test_boat_marker.py +++ b/tests/plugins/test_boat_marker.py @@ -26,7 +26,7 @@ def test_boat_marker(): out = normalize(m._parent.render()) # We verify that the script import is present. - script = '' # noqa + script = '' # noqa assert script in out # We verify that the script part is correct. diff --git a/tests/plugins/test_dual_map.py b/tests/plugins/test_dual_map.py index 30cee8ae10..b634f93a9a 100644 --- a/tests/plugins/test_dual_map.py +++ b/tests/plugins/test_dual_map.py @@ -20,7 +20,7 @@ def test_dual_map(): assert isinstance(figure, folium.Figure) out = normalize(figure.render()) - script = '' # noqa + script = '' # noqa assert script in out tmpl = Template(""" diff --git a/tests/plugins/test_tag_filter_button.py b/tests/plugins/test_tag_filter_button.py index ed05b60f07..a0e2dc8e82 100644 --- a/tests/plugins/test_tag_filter_button.py +++ b/tests/plugins/test_tag_filter_button.py @@ -34,11 +34,11 @@ def test_tag_filter_button(): out = normalize(m._parent.render()) # We verify that the script imports are present. - script = '' # noqa + script = '' # noqa assert script in out script = '' # noqa assert script in out - script = '' # noqa + script = '' # noqa assert script in out script = '' # noqa assert script in out