Skip to content

Review fixes for unified cebra implementation - #314

Draft
stes wants to merge 4 commits into
celia-unified-xcebra-reffrom
stes/unified-review
Draft

stes wants to merge 4 commits into
celia-unified-xcebra-reffrom
stes/unified-review

Conversation

@stes

@stes stes commented Nov 18, 2026

Copy link
Copy Markdown
Member

WIP, based on #313

- Remove unused numpy import in cebra/data/multiobjective.py (F401)
- Rename ambiguous loop variable `l` in tests (E741)
- Drop unused `W`/`rng` in neuron-gradient feature map test (F841)
- Import `_reference_implementations` as a module at the top of
  test_models.py instead of mid-file named imports (E402)
- Apply yapf/isort/trailing-whitespace fixes from pre-commit

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@cla-bot cla-bot Bot added the CLA signed label Nov 18, 2026
@stes
stes changed the base branch from main to celia-unified-xcebra-ref November 18, 2026 18:52
stes and others added 3 commits November 18, 2026 10:54
Add the trailing comma after "UnifiedSampler" so yapf's ending-comma
heuristic keeps one entry per line instead of packing the list.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Define the (offset, reference class) pairs once and reuse them in both
offset model tests, and import the local _reference_implementations
helper after the cebra imports.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant