Repository navigation
Conversation
brianjgeiger
requested changes
Nov 19, 2026
brianjgeiger
left a comment
Contributor
There was a problem hiding this comment.
There was a change to tags permissions that shouldn't be in here. Otherwise things seem good.
| }); | ||
|
|
||
| it('should mark tags and subjects read-only when project is read-only', () => { | ||
| it('should require admin access for registration tags', () => { |
Contributor
There was a problem hiding this comment.
Is this true? I thought Write users could modify tags. (Checking with Mark) No, bot write users and admins should be able to edit tags.
| return this.isRegistrationType() ? !this.hasAdminAccess() : !this.hasWriteAccess(); | ||
| }); | ||
| readonly isTagsReadOnly = computed( | ||
| () => this.isProjectReadOnly() || (this.isRegistrationType() ? !this.hasAdminAccess() : !this.hasWriteAccess()) |
Contributor
There was a problem hiding this comment.
This is not correct. Write users should be able to edit tags.
Collaborator
Author
There was a problem hiding this comment.
It was there before my changes. I can reproduce it on test3. I will fix it now.
brianjgeiger
approved these changes
Nov 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Screenshot(s)