Skip to content

[ENG-12802] FE: Disable resource type editing on registrations - #1104

Open
nsemets wants to merge 2 commits into
CenterForOpenScience:feature/pbs-26-22from
nsemets:fix/ENG-12802
Open

nsemets wants to merge 2 commits into
CenterForOpenScience:feature/pbs-26-22from
nsemets:fix/ENG-12802

Conversation

@nsemets

@nsemets nsemets commented Nov 19, 2026

Copy link
Copy Markdown
Collaborator

Summary of Changes

  1. Updated resource information dialog for registration.
  2. Updated metadata for registration.
  3. Updated unit tests.

Screenshot(s)

image image

@nsemets
nsemets requested a review from brianjgeiger November 19, 2026 13:22

@brianjgeiger brianjgeiger left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was a change to tags permissions that shouldn't be in here. Otherwise things seem good.

});

it('should mark tags and subjects read-only when project is read-only', () => {
it('should require admin access for registration tags', () => {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this true? I thought Write users could modify tags. (Checking with Mark) No, bot write users and admins should be able to edit tags.

return this.isRegistrationType() ? !this.hasAdminAccess() : !this.hasWriteAccess();
});
readonly isTagsReadOnly = computed(
() => this.isProjectReadOnly() || (this.isRegistrationType() ? !this.hasAdminAccess() : !this.hasWriteAccess())

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not correct. Write users should be able to edit tags.

@nsemets nsemets Nov 19, 2026 •

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was there before my changes. I can reproduce it on test3. I will fix it now.

@nsemets
nsemets requested a review from brianjgeiger November 19, 2026 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants