Repository navigation
[ENG-12678] Unable to submit a project to a collection after editing any section - #1105
Merged
brianjgeiger merged 2 commits intoNov 19, 2026
Conversation
nsemets
approved these changes
Nov 19, 2026
brianjgeiger
merged commit Nov 19, 2026
b1d7ee8
into
CenterForOpenScience:feature/pbs-26-22
3 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Submitting a project to a collection with a CEDAR template failed with "Submitted object must have a published CEDAR metadata record..." after any section was edited. When the Collection Metadata step opened again, the saved answers were loaded with
instanceObject, which doesn't rebuild the editor's validity report, so the record was saved as a draft and the submission was rejected. Update on an existing submission had the same issue and switched its published record back to draft.The CEDAR form on the project, registration and file metadata pages had the same problem: editing a published record and saving it, even without changes, turned it back to draft (ANG-630, ENG-11382). The draft button also showed a raw translation key (ENG-12424).
Summary of Changes
templateAndInstanceObject, so the editor rechecks them.templateAndInstanceObjecttoCedarEditorElement.Screenshot(s)
n/a
Side Effects
None expected. Incomplete metadata is still saved as a draft and blocked on submit.
QA Notes
Only reproducible with a template that has required fields (test3's Selenium Collection has a required Type, uat1's doesn't).