Repository navigation
Bound lookahead for common TSX generic arrow headers - #54
Open
Coding-Dev-Tools wants to merge 1 commit into
Open
Coding-Dev-Tools wants to merge 1 commit into
Coding-Dev-Tools wants to merge 1 commit into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Automated Code ReviewRuff lint: 0 issue(s)Ruff format: CleanSecret detection: 0 potential secret(s)Verdict: PASS Automated by Coding-Dev-Tools/.github reusable workflow. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TSX files with many short generic arrow declarations repeatedly lexed the next 8,192 characters for every generic head. Validate complete common direct-arrow headers using a short prefix, and retain the existing 8,192-character fallback for complex or inconclusive syntax.
The focused regression tests measure lexer input for 40, 100, and 400 declarations, cover the existing lookahead boundary, and check live CSS through scan, dry-run, and removal. Independent comparison preserves all 225 previous helper decisions and all 22 previous CSS outcomes, including the existing conservative cases.
Validation: Ruff lint and format checks; all 842 tests on Python 3.10, 3.11, 3.12, and 3.13 on Linux. Offline lock/dependency checks; one wheel and sdist build, Twine, and actual private wheel installation with generated console help and scan/dry-run/removal controls.
Addresses the post-merge review finding: #51 (comment)
Independent 2-Agent Review Status
7d33c7e4d69bbd018b391475a6ab0d1c9c9a384a(2 fresh Command Codedeepseek/deepseek-v4.1-flash --effort maxcontexts).APPROVE(0 blockers, 0 majors, 2 nits; 30,039-doc real-base differential & 55,985-input adversarial fuzz0mismatches) · Reviewer 2REQUEST_CHANGESsolely on branch commit7d33c7eauthor identity (Codex <codex@openai.com>, zero trailers in commit body; code, tests, lint, and wheel build all verified approve-quality).SUCCESS(test 3.10-3.13,Auto Code Review);ruff check&ruff format --checkpass;pytest tests/test_generic_header_lookahead.py23 passed; fullpytest tests/ -q838 passed, 1 skipped, 3 pre-existing Windows symlink WinError 1314 failures;uv buildsdist + wheel verified.merge-gate.ps1 -Method squashunder canonicalCoding-Dev-Toolsidentity with operator sign-off on squashing the pre-existingCodex-authored branch commit.