Repository navigation
Remove npm install line that installs someone else's package - #40
Open
Coding-Dev-Tools wants to merge 3 commits into
Open
Coding-Dev-Tools wants to merge 3 commits into
Coding-Dev-Tools wants to merge 3 commits into
Conversation
npm "json2sql" is an unrelated 2022 package owned by another user; this project has never been published to npm. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0111byzLrKKTCJ23uTT6PyZq
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
Automated Code ReviewRuff lint: 0 issue(s)Ruff format: Formatting neededSecret detection: 0 potential secret(s)Warnings: Lint/format issues Verdict: WARN Automated by Coding-Dev-Tools/.github reusable workflow. |
Verify README.md documents only supported git+ pip, Homebrew, and Scoop install paths and rejects the unrelated `npm install -g json2sql` string.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The README's "npm (Node.js wrapper)" section said
npm install -g json2sql. npmjson2sqlis an unrelated 2022 package owned by another user, and this project has never been published to npm asjson2sql, so anyone following the README installed someone else's code.What changes
npm install -g json2sqlsection fromREADME.md. The pipgit+https://, Homebrew, and Scoop instructions remain.tests/smoke.test.jsassertingREADME.mdretains the supported install instructions and does not re-introducenpm install -g json2sql.Validation
.venv\Scripts\python.exe -m ruff check src/ tests/ --target-version py310:All checks passed!.venv\Scripts\python.exe -m pytest tests/ -q: 173 passednpm test(node --test tests/*.test.js): 3 passed, 0 failedNote: initial branch commit
3b6f6ecpredates canonical commit hooks;merge-gate.ps1lands PRs via squash underCoding-Dev-Tools.Independent 2-Agent Review Status
011868fb59ebe0ab843c030f1445a14dd11f4589(2 fresh Command Codedeepseek/deepseek-v4.1-flash --effort maxcontexts).APPROVE· Reviewer 2APPROVE(0blockers; schema-v2 approval recorded atreview/approvals/json2sql-40-011868fb.json).SUCCESS(test 3.10-3.13,js-wrapper,Auto Code Review);pytest tests/ -q173 passed;ruff check src/ tests/ --target-version py310pass;npm test3 passed, 0 failed.tests/smoke.test.js:44regex catchesnpm install (-g|--global) json2sqlbut notnpm i -g json2sql,npx json2sql, orpnpm/yarnvariants inside fenced code blocks.CHANGELOG.md:48(Unreleased) still lists- npm install instructions added to README.3b6f6eccarries non-canonical author/trailers; must merge viamerge-gate.ps1 -Method squashunderCoding-Dev-Tools.