Repository navigation
Use semi-annual coupons for Australia, Japan and New Zealand bond markets - #467
Merged
domokane merged 1 commit intoNov 22, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_bond_market_conventionsreturnsFrequencyTypes.ANNUALforAUSTRALIA,JAPANandNEW_ZEALAND, but government bonds in all three markets pay fixed coupons twice a year, so aBondbuilt from these conventions gets the wrong cash flows. This changes the three entries toSEMI_ANNUAL; the day count, settlement days and ex-dividend days are unchanged.References:
Added
test_bond_market_semi_annual_couponstotests/unit/test_bond.py; it fails without the change and the full unit suite passes with it (1881 passed). Nothing else in the repo uses these three markets, so no golden files change.