Repository navigation
test: wait for the channel mute to reach member reads - #286
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ChannelTest > Can mute a channelfails on most CI runs. It mutes a channel and reads the member back at once, and the read can come from an API node that still holds the user from before the mute.Solution
The two member reads poll with the existing
waitForhelper untilnotifications_mutedis true. The same change went into stream-chat-net for the same reason.How to verify
Can mute a channel.Note
Low Risk
Test-only change; no production or API behavior is modified.
Overview
Stabilizes Can mute a channel by polling member reads after a mute instead of asserting immediately. Both checks—plain
Channel.queryMembers()and the same query withfilterCondition("notifications_muted", true)—now run inside the existingwaitForhelper until the test user’s member reportsnotifications_mutedas true, with a comment noting short-lived API node caching for offline users.Reviewed by Cursor Bugbot for commit 3f41046. Bugbot is set up for automated code reviews on this repo. Configure here.