Repository navigation
Form screen recording: respect the Microphone setting, mic off by default (#229336) - #224
Merged
Merged
Conversation
…ault (#229336) The feedback form's "Record screen" (GleapScreenRecorder) ignored Developer options → Microphone (flowConfig.capture.allowMicrophone) and started with the microphone on, so it called getUserMedia on every recording. On a site that already holds microphone permission the browser grants that without a prompt, and the recording had sound although the project had the microphone off. Only capture requests checked the setting. - The recorder asks for the microphone only when allowMicrophone is true and the browser has getUserMedia, read on every use. - With the setting on, the microphone is opt-in: off until the user turns it on, like capture requests. - The toolbar's mic button is hidden when the setting is off, and for a recording that started without the microphone (it can't be added then); it comes back for the next recording. Gleap ticket: https://app.gleap.io/projects/613b5dd730aed737108f87ab/bugs/6afd9df1768dffc58cb92c62 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…roject allows it Developer options → Microphone (flowConfig.capture.allowMicrophone) decides whether the feedback form's "Record screen" may ask for the microphone, and with it on the microphone is off until the user turns it on, like capture requests. Two existing tests change because that default changes: they started with the microphone on. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… off by default The feedback form's "Record screen" ignored Developer options → Microphone (flowConfig.capture.allowMicrophone) and started with the microphone on, so every recording called getUserMedia. On a site that already holds microphone permission the browser grants that without a prompt, and the recording had sound although the project had the microphone off. Only capture requests checked the setting. - The recorder asks for the microphone only when allowMicrophone is true and the browser has getUserMedia, read on every use. - With the setting on, the microphone is off until the user turns it on, like capture requests. - The toolbar's mic button is hidden when the setting is off, and for a recording that started without the microphone (it can't be added then); it is back for the next recording. Its rendering moves to GleapScreenRecorderMicButton.js, and the tooltip is set as text. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
LucaB01
approved these changes
Nov 18, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The feedback form's Record screen (
GleapScreenRecorder) ignored Developer options → Microphone (flowConfig.capture.allowMicrophone) and started with the microphone on, so every recording calledgetUserMedia({ audio }). On a site that already holds microphone permission (for example a calling app), the browser grants that without a prompt, and the recording had sound even though the project had the microphone off. Only capture requests (GleapCaptureManager.micState) checked the setting.Gleap ticket #229336: https://app.gleap.io/projects/613b5dd730aed737108f87ab/bugs/6afd9df1768dffc58cb92c62
Fix
allowMicrophone === trueand the browser hasgetUserMedia. The setting is read on every use, not cached when the form opens.GleapMarkerManager.js(already over the size limit) to the newGleapScreenRecorderMicButton.js, withMIC_BUTTONas frozen constants. The tooltip is now set withtextContentinstead ofinnerHTML.Behaviour change: please confirm
AGENTS.mdsays a missing setting keeps today's behaviour. Here it doesn't: a project that never touched Microphone (missing means off, as the dashboard shows it) no longer gets sound in form recordings, and with the setting on the microphone starts muted. Sites onlatestget this with the merge. This is deliberate. The dashboard already shows the setting as off, and recording sound the project turned off is a privacy bug. Still, it changes what customers get today, so it needs a product yes before merging.Tests
3fc2c5c), seen failing against master. Two existing tests inGleapScreenRecorder.test.jschanged because the required default changed: they started with the microphone on. TheDisplayRecordingmock now returns a microphone track only when one was asked for, like the real engine.GleapScreenRecorderMicButton.test.js(jsdom) for the button states.npx vitest related src/GleapScreenRecorder.js src/GleapMarkerManager.js src/GleapScreenRecorderMicButton.js --run: 25 files, 419 tests pass.node tools/quality/check.mjs: 0 problems, 0 warnings.npm run build/npm run test:smoke(no public API, load-time or build change; CI runs both). Not checked in a real browser.Notes
177bd62brings that version over the first commit without a force-push. The diff against master is only the five files above.CHANGELOG.mdentry yet: it goes in with the release that ships this.🤖 Generated with Claude Code