Repository navigation
fix: align production Roslyn package versions - #539
Open
BenjaminMichaelis wants to merge 1 commit into
Open
BenjaminMichaelis wants to merge 1 commit into
BenjaminMichaelis wants to merge 1 commit into
Conversation
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Roslyn 5.6.0 dependencies prevent the analyzer from loading on supported .NET 8/9 compiler hosts and code fixes from loading in older IDE hosts, disabling diagnostics and fixes.
1 open issue
What changed in this PR
This PR aligns the analyzer and code-fix projects with the centrally managed Roslyn 5.6.0 packages already used by tests.
Changes:
- Removes the analyzer’s Roslyn 4.8.0 version override.
- Removes the code-fix project’s Workspaces 4.8.0 version override.
| File | Description |
|---|---|
| IntelliTect.Analyzer/IntelliTect.Analyzer/IntelliTect.Analyzer.csproj | Uses the central Microsoft.CodeAnalysis.CSharp version. |
| IntelliTect.Analyzer/IntelliTect.Analyzer.CodeFixes/IntelliTect.Analyzer.CodeFixes.csproj | Uses the central Microsoft.CodeAnalysis.CSharp.Workspaces version. |
Review effort: Balanced
| <ItemGroup> | ||
| <PackageReference Include="Microsoft.CodeAnalysis.Analyzers" PrivateAssets="all" /> | ||
| <PackageReference Include="Microsoft.CodeAnalysis.CSharp" PrivateAssets="all" VersionOverride="4.8.0" /> | ||
| <PackageReference Include="Microsoft.CodeAnalysis.CSharp" PrivateAssets="all" /> |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Validation