Skip to content

Don't jump the commit page when you tap into the reply bar - #205

Draft
simonhamp wants to merge 1 commit into
mainfrom
fix/reply-tap-no-jump
Draft

simonhamp wants to merge 1 commit into
mainfrom
fix/reply-tap-no-jump

Conversation

@simonhamp

Copy link
Copy Markdown
Member

Tapping into the reply bar on a commit's page used to fold the earlier commits away and remount the scroll view at the top, so the commit being answered came back into view. Simon doesn't want that any more: the page now stays where it is when you tap the field.

This removes CommitDetail::replyTapped(), the field's @pressUp, and the $scrollKey that only existed to remount the scroll view. The scroll view keeps a fixed key.

Watch for: #196 (nested replies) also uses $scrollKey and replyTapped(), so whichever merges second needs a small conflict fix.

Tests: the old "brings the commit back up" test is now "leaves the page where it is", and fails on the old code. The keyboard-stays-up test folds the earlier commits by setting the state directly instead of through the tap. Full suite: 2034 passed.

🤖 Generated with Claude Code

Tapping the reply field used to fold the earlier commits away and mount
the scroll view again at the top, to bring the commit being answered back
into view. Now the page stays where it is.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant