Repository navigation
Conversation
Tapping the reply field used to fold the earlier commits away and mount the scroll view again at the top, to bring the commit being answered back into view. Now the page stays where it is. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tapping into the reply bar on a commit's page used to fold the earlier commits away and remount the scroll view at the top, so the commit being answered came back into view. Simon doesn't want that any more: the page now stays where it is when you tap the field.
This removes
CommitDetail::replyTapped(), the field's@pressUp, and the$scrollKeythat only existed to remount the scroll view. The scroll view keeps a fixed key.Watch for: #196 (nested replies) also uses
$scrollKeyandreplyTapped(), so whichever merges second needs a small conflict fix.Tests: the old "brings the commit back up" test is now "leaves the page where it is", and fails on the old code. The keyboard-stays-up test folds the earlier commits by setting the state directly instead of through the tap. Full suite: 2034 passed.
🤖 Generated with Claude Code