Skip to content

Use the compact link row under a commit's own images - #207

Draft
simonhamp wants to merge 1 commit into
mainfrom
fix/video-card-with-photos
Draft

simonhamp wants to merge 1 commit into
mainfrom
fix/video-card-with-photos

Conversation

@simonhamp

Copy link
Copy Markdown
Member

A commit with photos and a YouTube link showed both the photos and the full video card (#202), so the post carried two large pictures. With photos attached, the video now shows as the compact link row (site, title, description) instead of its player, and the compact row leaves out its own thumbnail. Commits without photos are unchanged.

Watch for: the compact row for a video uses devnull's preview title. Before the oEmbed lookup lands that can be YouTube's generic "- YouTube" title, the same as any other link row.

Tests: two new cases in CommitEmbedTest, one for a video and one for an ordinary link preview, both under a commit's own image. Both fail on the old view. Full suite: 2036 passed.

🤖 Generated with Claude Code

A YouTube link drew its full player card even when the commit had photos,
so the post showed two big pictures. With photos attached, a video now
gets the compact link row instead, and link rows drop their thumbnail.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant