Repository navigation
fix: Settings — Cancel and Save as two equal halves, 6dp after a radio's text (2.27.2) - #293
Conversation
PR Summary by QodoFix Settings dialog button layout and control spacing
AI Description
Merge Risk
|
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can turn on the rule miner and Qodo learns your standards from review history |
Closes #292. Two brass rules found missed in the 2.27.1 Settings dialog by the brand review.
Brass.halves()reuses the dialog's button bar: Cancel left, Save right, two equal halves (weight 1, 6dp margins, as camex 4.3.1). On Android TV the bar put Save first and packed both to the left. Only the Settings dialog uses it.Checked:
compot/android:2026.10:testDebugUnitTest lintDebug assembleDebug, lint 13 warnings as the baseline.tests/e2e.shTRANSPORT=TCP: API 21 20/20, API 34 20/20.