Repository navigation
fix: Cancel and Save as two equal halves in every window (2.27.3) - #295
Conversation
The brass rule for Cancel / Save is now for all windows (#294): Brass.style() lays out any dialog with both buttons as two equal halves, Cancel left, so the camera URL dialog and the Reset confirmation follow Settings (#292); the focused button keeps the focus (Cancel in Reset). focus_ring.xml header to brass 1.4.2 (comment only). Closes #294
PR Summary by QodoApply equal-width Cancel and action buttons to all brass dialogs
AI Description
Merge Risk
|
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can turn on the rule miner and Qodo learns your standards from review history |
Closes #294. The brass rule for Cancel / Save now covers all windows (brand, 2026-11-20).
Brass.style()now lays out every dialog that has both a negative and a positive button as two equal halves: Cancel left, the other right, weight 1, 6dp margins. This covers the camera URL dialog and the Reset confirmation (Cancel / Clear settings), the same as Settings in 2.27.2 (Settings: 6dp after radio text; Cancel and Save as two equal halves (brass) #292).focus_ring.xmlheader is updated to brass 1.4.2 (comment only; the drawing is unchanged).Checked:
compot/android:2026.10:testDebugUnitTest lintDebug assembleDebug; lint 13 warnings, as in the baseline.tests/e2e.shTRANSPORT=TCP: API 21 20/20, API 34 20/20.