Skip to content

fix: camex 5.2.1 in the tunnel (2.28.0) - #299

Merged
compot-dev merged 1 commit into
v2from
fix/camex-5.2.1-298
Nov 22, 2026
Merged

compot-dev merged 1 commit into
v2from
fix/camex-5.2.1-298

Conversation

@compot-dev

Copy link
Copy Markdown
Collaborator

Closes #298.

  • bundles/camex: 4.4.1 → 5.2.1 (9b1c7a3). The library is camex's client profile, built by its own CMake.
  • Settings gets the library's new Network name field (hidden, with Show the key); with it the server key and psk may stay empty. No Decoder code change: the form is built from the library's fields.
  • An empty MTU is now 1420 over UDP and 1500 over TCP; TunnelPath comment updated.
  • tests/e2e.sh: the restart marker is camex 5's Tunnel up: (was Tunnel initialized).
  • README (en/ru/zh-CN): camex 5.2.1, the new field and the MTU default. Version 2.28.0 (versionCode 68).

Checked locally in Docker: unit tests, lint (13 warnings, as the baseline), assembleDebug, check-version.sh; e2e on API 21 and 34: UDP 19/19, TCP 20/20.

Closes #298. The e2e restart check looks for camex 5's "Tunnel up:" log line.
@qodo-free-for-open-source-projects

qodo-free-for-open-source-projects Bot commented Nov 22, 2026 •

Copy link
Copy Markdown

PR Summary by Qodo

Upgrade the camex tunnel to 5.2.1 and expose Network name

🐞 Bug fix ✨ Enhancement 📝 Documentation 🕐 20-40 Minutes

Grey Divider

AI Description

• Upgrade the bundled camex client to 5.2.1, exposing Network name through its field-driven settings
 form.
• Update the tunnel restart check for camex 5’s log message and document transport-specific MTU
 defaults.
• Release as 2.28.0 with updated English, Russian, and Chinese documentation.
Merge Risk 🟡 Medium

Blast radius 🟡 Medium 💥 2 capabilities

  • 2 affected capabilities within one bounded functional scope: camex tunnel integration.
  • This is the camera-viewing outcome of the same bounded camex integration.
  • The tunnel supplies reachability and Decoder's RTSP session consumes it; the implementation hops are represented in the path rather than treated as separate capabilities.
  • This is a distinct useful operation from camera playback—the remote debug-page ingress—but it shares the same bounded camex tunnel integration and its dynamically announced web-port contract.
  • It is not an independent deployment or functional domain.
Sources

bundles/camex[1-1]

Subproject commit 9b1c7a3bd14818f7dce4827dd862099c4f93cfab

android/app/src/main/java/com/openipc/decoder/NetworkPanel.java[38-40]

 * The camex tunnel (the library of bundles/camex): the Network screen is built from its fields,
 * the values are kept in Decoder's settings as {@code tunnel_camex_<key>} (the psk sealed with
 * {@link CredentialStore}), and {@code tunnel_on} connects now and at every start of the app.
Behavioral complexity 🟡 Medium 🧩 Compatibility cases, Interacting branches

  • Before: Decoder persisted the camex library's field values and started the prior library using the saved profile; empty MTU and key handling followed the prior release's semantics.
  • After: the bundled library changes to 5.2.1, adding network-name-based server selection/key omission and protocol-specific empty-MTU defaults while retaining compatibility with older servers.
  • New correctness condition: the new library must correctly reconcile legacy stored fields, network-name versus explicit key/PSK precedence, UDP versus TCP MTU defaults, and Decoder's dynamically supplied web-port value across startup, reconnect, and Save-triggered restart.
  • These are compatibility and state/branch interactions introduced by the changed dependency, not complexity inferred merely from the existence of a VPN or retry helper.
  • The exact internal state machine remains partly unverified because the submodule source is unavailable.
Sources

bundles/camex[1-1]

Subproject commit 9b1c7a3bd14818f7dce4827dd862099c4f93cfab

android/app/src/main/java/com/openipc/decoder/NetworkPanel.java[38-40]

 * The camex tunnel (the library of bundles/camex): the Network screen is built from its fields,
 * the values are kept in Decoder's settings as {@code tunnel_camex_<key>} (the psk sealed with
 * {@link CredentialStore}), and {@code tunnel_on} connects now and at every start of the app.
Potential damage 🟡 Medium 🩹 Temporary loss

  • If activated and the new library fails to establish the tunnel or its routes/port gate, camera viewing through camex and remote debug-page access through camex can be unavailable.
  • This is a recoverable service outage rather than persistent state corruption: reverting the APK or correcting the profile can restore operation, but the evidence does not prove automatic repair.
  • Local Decoder behavior outside the tunnel is preserved.
  • The equal-importance baseline is used; no business-criticality declaration was supplied.
  • Revert to the prior app/library or correct the saved network-name/key, protocol, or MTU settings and restart the tunnel.
  • Recovery may require VPN consent and a reachable compatible camex server.
  • Reverting code alone does not necessarily repair a malformed or newly adopted persisted profile; that may require editing the profile.
  • No external irreversible effect or persistent camera data mutation is indicated.
Sources

bundles/camex[1-1]

Subproject commit 9b1c7a3bd14818f7dce4827dd862099c4f93cfab

android/app/src/main/java/com/openipc/decoder/NetworkPanel.java[38-40]

 * The camex tunnel (the library of bundles/camex): the Network screen is built from its fields,
 * the values are kept in Decoder's settings as {@code tunnel_camex_<key>} (the psk sealed with
 * {@link CredentialStore}), and {@code tunnel_on} connects now and at every start of the app.
Assessed commit e71c083
Diagram

graph TD
  Camex["Camex 5.2.1"] -->|field metadata| Panel["Network settings"] --> Prefs["Saved settings"] --> Camex
  Camex --> VPN["Android VPN"]
Loading
High-Level Assessment

Retaining the library-driven settings form is the right approach: it exposes Network name and uses camex’s validation without duplicating its field definitions in Decoder. A custom app-side field would add a second source of truth without a clear benefit.

Files changed (8) +18 / -9

Tests (1) +1 / -1
e2e.shRecognize the camex 5 tunnel restart log +1/-1

Recognize the camex 5 tunnel restart log

• Changes the restart assertion’s log marker from “Tunnel initialized” to “Tunnel up:” so the end-to-end test recognizes a new camex 5 tunnel run.

tests/e2e.sh

Documentation (5) +14 / -5
CHANGELOG.mdRecord the 2.28.0 tunnel release +8/-0

Record the 2.28.0 tunnel release

• Adds release notes for camex 5.2.1, Network name and optional keys, transport-specific empty-MTU defaults, and protocol compatibility with camex 4.x servers.

CHANGELOG.md

README.mdDocument the upgraded tunnel in English +1/-1

Document the upgraded tunnel in English

• Updates the camex version and explains Network name, key visibility, and the UDP and TCP MTU defaults.

README.md

README.ru.mdDocument the upgraded tunnel in Russian +1/-1

Document the upgraded tunnel in Russian

• Updates the camex version and describes Network name, optional keys, key visibility, and MTU defaults.

README.ru.md

README.zh-CN.mdDocument the upgraded tunnel in Simplified Chinese +1/-1

Document the upgraded tunnel in Simplified Chinese

• Updates the camex version and describes Network name, optional keys, key visibility, and MTU defaults.

README.zh-CN.md

TunnelPath.javaClarify the tunnel MTU rationale +3/-2

Clarify the tunnel MTU rationale

• Updates the comment explaining TCP playback over VPN paths to reflect camex’s 1420-byte UDP default. No path-detection behavior changes.

android/app/src/main/java/com/openipc/decoder/TunnelPath.java

Other (2) +3 / -3
build.gradleSet the Android release version to 2.28.0 +2/-2

Set the Android release version to 2.28.0

• Increments versionCode from 67 to 68 and versionName from 2.27.4 to 2.28.0.

android/app/build.gradle

camexAdvance the camex client submodule to 5.2.1 +1/-1

Advance the camex client submodule to 5.2.1

• Moves the bundled client profile to commit 9b1c7a3, bringing its Network name field and updated tunnel behavior into the Android integration. Decoder’s existing field-driven form consumes the library’s fields without an app-side form change.

bundles/camex

@qodo-free-for-open-source-projects

qodo-free-for-open-source-projects Bot commented Nov 22, 2026 •

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (1) 🎨 UX issues (0) 🔗 Cross-repo conflicts (0) 📜 Skill insights (0)

Grey Divider


Remediation recommended

1. Release ships as minor, not patch 📎 Requirement gap ⚙ Maintainability
Description
The versionName moves from 2.27.4 to 2.28.0 and the CHANGELOG adds a ## 2.28.0 section, so the
camex upgrade is versioned as a MINOR release rather than the PATCH release the ticket plans. This
triggers on every build and release made from this PR, and it reaches the version number, the
CHANGELOG heading and anything that keys off them.
Code

android/app/build.gradle[R29-30]

+        versionCode 68
+        versionName "2.28.0"
Evidence
Rule 7 requires the upgrade to be included in a PATCH release, and its failure criteria include the
planned PATCH release not being made. The diff sets versionName from 2.27.4 to 2.28.0 (a minor bump)
and adds a 2.28.0 CHANGELOG entry, so the release does not match the planned PATCH.

Update documentation and PATCH release
android/app/build.gradle[29-30]
CHANGELOG.md[15-21]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The ticket plans the camex 5.2.1 upgrade as a PATCH release. This PR instead sets the release to 2.28.0, a MINOR bump, in `android/app/build.gradle` and in the CHANGELOG heading.
## Fix Focus Areas
- android/app/build.gradle[29-30]
- CHANGELOG.md[15-21]
## Recommended Fix
Change `versionName` to "2.27.5" and keep `versionCode` incrementing (68). Rename the CHANGELOG heading and the `2.28.0` references to `2.27.5`. If a MINOR release is intended, record that decision and the reason in the ticket or PR description instead.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Grey Divider

Tip of the day
💡 Did you know, you can route each severity your way: inline, summary, both, or drop

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

@compot-dev

Copy link
Copy Markdown
Collaborator Author

Qodo (release ships as minor, not patch): the PR is right and the issue's plan was wrong. The settings form gets a new field (Network name), which is a new feature, so the release is MINOR (2.28.0) by the project's versioning rule. #298 now says so.

@compot-dev
compot-dev merged commit de05648 into v2 Nov 22, 2026
7 checks passed
@compot-dev
compot-dev deleted the fix/camex-5.2.1-298 branch November 22, 2026 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

camex 5.2.1 in the tunnel

1 participant