Repository navigation
Conversation
) send_packet and the agg limits carried their own copies of the speed-to-MPS expression and the PKT_OFFSET boundary test. Use usb_bulk_mps() and single_block_pkt_offset() from TxAggPlan.h instead. Same values on every speed; the RTL8733B is USB-only, so no PCIe guard. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011dReg158JQxkhEWGPBro5f
PR Summary by QodoRTL8733B: reuse shared USB bulk-boundary helpers
AI Description
Merge Risk
|
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can add REVIEW.md to your repo root and Qodo follows it on every PR |
The last hand-written copy of the speed-to-MPS expression. Same values on every speed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011dReg158JQxkhEWGPBro5f
|
This one is superseded: #594 landed the same three changes on master ( The 8733BU negative control in the description (0 of 658 lost with the pad, 637 of 652 with the offset forced to 0) is the one thing here master doesn't record — useful evidence that the RTL8733B has the same fault as Jaguar2/3 and that its existing pad is what prevents it. |
|
Closing as superseded by #594 (see the comment above); the same changes are on master. |
What this is
Follow-up to the first non-blocking note on #592:
Rtl8733bDevice::send_packetalready applied the bulk-boundary pad, but with its own copy of the speed-to-MPS expression. So did the agg limits insend_packets. Both now callusb_bulk_mps()andsingle_block_pkt_offset()fromTxAggPlan.h.What changed
src/rtl8733b/Rtl8733bDevice.cpp: two inline expressions become helper calls (+3 / −10). The RTL8733B is USB-only, so it needs nois_usb()guard.src/jaguar1/RtlJaguarDevice.cpp: its agg limits held the last hand-written copy of the speed-to-MPS expression; it now callsusb_bulk_mps()(+1 / −3).The values are the same for every speed (the helper uses the same thresholds; unknown speeds give 64).
Verification
8733BU sender (USB2, so MPS 512; descriptor 40 bytes) to an 8812BU, ch36, MCS4, 60 s. Every 50th frame is cut to a 984-byte MPDU (40 + 984 = 1024).
ctest92/92; no new warnings.Not covered
send_built_block(only reached on a malformed frame or an endpoint mismatch).🤖 Generated with Claude Code