Skip to content

Rename ACL resource to Microsoft.Windows.Filesystem/AccessControlList - #1819

Merged
Steve Lee (SteveL-MSFT) merged 1 commit into
mainfrom
stevel-msft-filesystem-acl-rename
Nov 18, 2026
Merged

Steve Lee (SteveL-MSFT) merged 1 commit into
mainfrom
stevel-msft-filesystem-acl-rename

Conversation

@SteveL-MSFT

Copy link
Copy Markdown
Member

Rename Microsoft.Filesystem/ACL to Microsoft.Windows.Filesystem/AccessControlList to make its Windows scope explicit and use the full resource name.

Updates the manifest identity and existing Pester test references without changing ACL behavior. Configurations using the old type must switch to the new name.

Validation: manifest identity and operation mappings, PowerShell syntax, and absence of old resource references checked. Runtime tests were not run because this worktree has no built DSC executable.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings November 17, 2026 23:28

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues remain for the ACL resource rename and corresponding test-reference updates.

No open issues 🎉

What changed in this PR

Renames the ACL resource to Microsoft.Windows.Filesystem/AccessControlList, making its Windows scope explicit without changing ACL behavior. Existing configurations must adopt the new resource type.

Changes:

  • Updates the resource identity in the manifest.
  • Updates the Pester test label and resource-type reference to match.
File Description
resources/​file_dsc/​tests/​filesystem_acl.tests.ps1 Uses the new resource name in the test label and resource lookup.
resources/​file_dsc/​file_dsc.dsc.manifests.json Renames the manifest’s resource type.

Review effort: Balanced

@github-actions

Copy link
Copy Markdown

Code Coverage Report

No Rust files were changed in this PR.

🔵 Full Codebase Coverage

83% (good)

Metric Value
Total executable lines 22106
Lines covered by tests 18565
Coverage percentage 83%

Full codebase coverage measures all instrumented Rust lines across the project.

@SteveL-MSFT
Steve Lee (SteveL-MSFT) merged commit 4fe2a41 into main Nov 18, 2026
32 checks passed
@SteveL-MSFT
Steve Lee (SteveL-MSFT) deleted the stevel-msft-filesystem-acl-rename branch November 18, 2026 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants