Repository navigation
Rename ACL resource to Microsoft.Windows.Filesystem/AccessControlList - #1819
Merged
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain for the ACL resource rename and corresponding test-reference updates.
No open issues 🎉
What changed in this PR
Renames the ACL resource to Microsoft.Windows.Filesystem/AccessControlList, making its Windows scope explicit without changing ACL behavior. Existing configurations must adopt the new resource type.
Changes:
- Updates the resource identity in the manifest.
- Updates the Pester test label and resource-type reference to match.
| File | Description |
|---|---|
resources/file_dsc/tests/filesystem_acl.tests.ps1 |
Uses the new resource name in the test label and resource lookup. |
resources/file_dsc/file_dsc.dsc.manifests.json |
Renames the manifest’s resource type. |
Review effort: Balanced
Code Coverage ReportNo Rust files were changed in this PR. 🔵 Full Codebase Coverage83% (good)
|
Steve Lee (SteveL-MSFT)
deleted the
stevel-msft-filesystem-acl-rename
branch
November 18, 2026 00:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename
Microsoft.Filesystem/ACLtoMicrosoft.Windows.Filesystem/AccessControlListto make its Windows scope explicit and use the full resource name.Updates the manifest identity and existing Pester test references without changing ACL behavior. Configurations using the old type must switch to the new name.
Validation: manifest identity and operation mappings, PowerShell syntax, and absence of old resource references checked. Runtime tests were not run because this worktree has no built DSC executable.