Skip to content

Add ProductVersion and FileVersion resource strings to Windows built executables - #1823

Merged
Steve Lee (SteveL-MSFT) merged 3 commits into
mainfrom
win-resource-strings
Nov 19, 2026
Merged

Steve Lee (SteveL-MSFT) merged 3 commits into
mainfrom
win-resource-strings

Conversation

@SteveL-MSFT

Copy link
Copy Markdown
Member

PR Summary

Use the winresource crate to add resource strings (specifically the ProductVersion and FileVersion) to Windows built executables.

PR Context

Fix #1820

Apply the DSC winresource build pattern to the remaining binaries and verify nonempty file and product versions with Pester.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings November 18, 2026 23:58

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The test can select stale debug binaries during release runs and miss architecture-specific outputs, potentially masking missing version resources or failing to find binaries.

1 open issue
What changed in this PR

Adds embedded Windows version information to DSC executables, supporting file inventory without running each executable and addressing #1820.

Changes:

  • Adds the shared winresource build dependency and updates the lockfile.
  • Adds Windows-only resource compilation across the CLI, resources, adapters, and tools.
  • Adds a Windows Pester test for nonempty ProductVersion and FileVersion metadata.
File Description
y2j/​Cargo.toml Adds resource build dependency.
y2j/​build.rs Embeds Windows version metadata.
xtask/​Cargo.toml Adds resource build dependency.
xtask/​build.rs Embeds Windows version metadata.
tools/​test_group_resource/​Cargo.toml Adds resource build dependency.
tools/​test_group_resource/​build.rs Embeds Windows version metadata.
tools/​dsctest/​Cargo.toml Adds resource build dependency.
tools/​dsctest/​build.rs Embeds Windows version metadata.
resources/​WindowsUpdate/​Cargo.toml Adds resource build dependency.
resources/​WindowsUpdate/​build.rs Embeds Windows version metadata.
resources/​windows_service/​Cargo.toml Adds resource build dependency.
resources/​windows_service/​build.rs Embeds Windows version metadata.
resources/​windows_security_policy/​Cargo.toml Adds resource build dependency.
resources/​windows_security_policy/​build.rs Embeds Windows version metadata.
resources/​windows_firewall/​Cargo.toml Adds resource build dependency.
resources/​windows_firewall/​build.rs Embeds Windows version metadata.
resources/​windows_audit_policy/​Cargo.toml Adds resource build dependency.
resources/​windows_audit_policy/​build.rs Embeds Windows version metadata.
resources/​sshdconfig/​Cargo.toml Adds resource build dependency.
resources/​sshdconfig/​build.rs Embeds Windows version metadata.
resources/​runcommandonset/​Cargo.toml Adds resource build dependency.
resources/​runcommandonset/​build.rs Embeds Windows version metadata.
resources/​registry/​Cargo.toml Adds resource build dependency.
resources/​registry/​build.rs Embeds Windows version metadata.
resources/​process/​Cargo.toml Adds resource build dependency.
resources/​process/​build.rs Embeds Windows version metadata.
resources/​osinfo/​Cargo.toml Adds resource build dependency.
resources/​osinfo/​build.rs Embeds Windows version metadata.
resources/​file_dsc/​Cargo.toml Adds resource build dependency.
resources/​file_dsc/​build.rs Embeds Windows version metadata.
resources/​environment_variable/​Cargo.toml Adds resource build dependency.
resources/​environment_variable/​build.rs Embeds Windows version metadata.
resources/​dscecho/​Cargo.toml Adds resource build dependency.
resources/​dscecho/​build.rs Embeds Windows version metadata.
resources/​dism_dsc/​Cargo.toml Adds resource build dependency.
resources/​dism_dsc/​build.rs Embeds Windows version metadata.
dsc/​tests/​other/​dsc_fileversion.tests.ps1 Checks executable version metadata on Windows.
dsc/​Cargo.toml Adds resource build dependency.
dsc/​build.rs Embeds CLI version metadata on Windows.
dsc-bicep-ext/​Cargo.toml Adds resource build dependency.
dsc-bicep-ext/​build.rs Adds Windows metadata compilation alongside protobuf generation.
Cargo.toml Declares shared winresource dependency.
Cargo.lock Locks new build dependencies.
adapters/​group_policy_template/​Cargo.toml Adds resource build dependency.
adapters/​group_policy_template/​build.rs Embeds Windows version metadata.
adapters/​csp/​Cargo.toml Adds resource build dependency.
adapters/​csp/​build.rs Embeds Windows version metadata.

Review effort: Balanced

@SteveL-MSFT Steve Lee (SteveL-MSFT) changed the title Win resource strings Add ProductVersion and FileVersion resource strings to Windows built executables Nov 19, 2026
@github-actions

Copy link
Copy Markdown

😲 Code Coverage Report

Changed Code Coverage

100% (100% coverage)

Metric Value
Changed lines analyzed 0
Lines covered by tests 0
Coverage percentage 100%

🔵 Full Codebase Coverage

83% (good)

Metric Value
Total executable lines 22106
Lines covered by tests 18565
Coverage percentage 83%

Changed code coverage measures only Rust lines added/modified in this PR.
Full codebase coverage measures all instrumented Rust lines across the project.

@SteveL-MSFT
Steve Lee (SteveL-MSFT) merged commit b9040ac into main Nov 19, 2026
31 checks passed
@SteveL-MSFT
Steve Lee (SteveL-MSFT) deleted the win-resource-strings branch November 19, 2026 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Embed version in executables

2 participants