Repository navigation
Add ProductVersion and FileVersion resource strings to Windows built executables - #1823
Merged
Merged
Conversation
Apply the DSC winresource build pattern to the remaining binaries and verify nonempty file and product versions with Pester. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The test can select stale debug binaries during release runs and miss architecture-specific outputs, potentially masking missing version resources or failing to find binaries.
1 open issue
What changed in this PR
Adds embedded Windows version information to DSC executables, supporting file inventory without running each executable and addressing #1820.
Changes:
- Adds the shared
winresourcebuild dependency and updates the lockfile. - Adds Windows-only resource compilation across the CLI, resources, adapters, and tools.
- Adds a Windows Pester test for nonempty
ProductVersionandFileVersionmetadata.
| File | Description |
|---|---|
| y2j/Cargo.toml | Adds resource build dependency. |
| y2j/build.rs | Embeds Windows version metadata. |
| xtask/Cargo.toml | Adds resource build dependency. |
| xtask/build.rs | Embeds Windows version metadata. |
| tools/test_group_resource/Cargo.toml | Adds resource build dependency. |
| tools/test_group_resource/build.rs | Embeds Windows version metadata. |
| tools/dsctest/Cargo.toml | Adds resource build dependency. |
| tools/dsctest/build.rs | Embeds Windows version metadata. |
| resources/WindowsUpdate/Cargo.toml | Adds resource build dependency. |
| resources/WindowsUpdate/build.rs | Embeds Windows version metadata. |
| resources/windows_service/Cargo.toml | Adds resource build dependency. |
| resources/windows_service/build.rs | Embeds Windows version metadata. |
| resources/windows_security_policy/Cargo.toml | Adds resource build dependency. |
| resources/windows_security_policy/build.rs | Embeds Windows version metadata. |
| resources/windows_firewall/Cargo.toml | Adds resource build dependency. |
| resources/windows_firewall/build.rs | Embeds Windows version metadata. |
| resources/windows_audit_policy/Cargo.toml | Adds resource build dependency. |
| resources/windows_audit_policy/build.rs | Embeds Windows version metadata. |
| resources/sshdconfig/Cargo.toml | Adds resource build dependency. |
| resources/sshdconfig/build.rs | Embeds Windows version metadata. |
| resources/runcommandonset/Cargo.toml | Adds resource build dependency. |
| resources/runcommandonset/build.rs | Embeds Windows version metadata. |
| resources/registry/Cargo.toml | Adds resource build dependency. |
| resources/registry/build.rs | Embeds Windows version metadata. |
| resources/process/Cargo.toml | Adds resource build dependency. |
| resources/process/build.rs | Embeds Windows version metadata. |
| resources/osinfo/Cargo.toml | Adds resource build dependency. |
| resources/osinfo/build.rs | Embeds Windows version metadata. |
| resources/file_dsc/Cargo.toml | Adds resource build dependency. |
| resources/file_dsc/build.rs | Embeds Windows version metadata. |
| resources/environment_variable/Cargo.toml | Adds resource build dependency. |
| resources/environment_variable/build.rs | Embeds Windows version metadata. |
| resources/dscecho/Cargo.toml | Adds resource build dependency. |
| resources/dscecho/build.rs | Embeds Windows version metadata. |
| resources/dism_dsc/Cargo.toml | Adds resource build dependency. |
| resources/dism_dsc/build.rs | Embeds Windows version metadata. |
| dsc/tests/other/dsc_fileversion.tests.ps1 | Checks executable version metadata on Windows. |
| dsc/Cargo.toml | Adds resource build dependency. |
| dsc/build.rs | Embeds CLI version metadata on Windows. |
| dsc-bicep-ext/Cargo.toml | Adds resource build dependency. |
| dsc-bicep-ext/build.rs | Adds Windows metadata compilation alongside protobuf generation. |
| Cargo.toml | Declares shared winresource dependency. |
| Cargo.lock | Locks new build dependencies. |
| adapters/group_policy_template/Cargo.toml | Adds resource build dependency. |
| adapters/group_policy_template/build.rs | Embeds Windows version metadata. |
| adapters/csp/Cargo.toml | Adds resource build dependency. |
| adapters/csp/build.rs | Embeds Windows version metadata. |
Review effort: Balanced
😲 Code Coverage ReportChanged Code Coverage100% (100% coverage)
🔵 Full Codebase Coverage83% (good)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

PR Summary
Use the
winresourcecrate to add resource strings (specifically the ProductVersion and FileVersion) to Windows built executables.PR Context
Fix #1820