Repository navigation
Rename the Bluetooth contract protocols - #6
Merged
Merged
Conversation
colemancda
force-pushed
the
feature/bluetooth-contract-names
branch
from
November 18, 2026 05:55
d08cbec to
058899d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Uses the new Swift names of the Bluetooth contracts from PureSwift/AppRuntime#34:
BluetoothCentral,BluetoothPeripheral,BluetoothService,BluetoothCharacteristic,BluetoothDescriptor,BluetoothAdvertisementand the two delegates, plus their…Proxyclasses. AppRuntime renamed them because they clashed with PureSwift/GATT's top-level types.The change is mechanical, in
LinuxBluetooth, its tests and the docs. Contract names on the wire (org.pureswift.bluetooth.Central…) are unchanged.Merge order
This needs PureSwift/AppRuntime#34. The manifest uses AppRuntime's
master, so this branch won't build against GitHub until #34 merges. Merge that first, then this.Testing
LinuxBluetoothTests: 12 tests passing in this repository's Docker image (Scripts/docker.sh), against AppRuntime#34's branch.Commits
One commit per file. The intermediate commits don't build on their own, because a contract's rename and its uses land in separate commits; the branch tip builds.