Skip to content

[finsh] bound path auto-complete buffer copies - #12057

Open
cms19859230182-lang wants to merge 1 commit into
RT-Thread:masterfrom
cms19859230182-lang:fix/finsh-path-complete-bounds
Open

cms19859230182-lang wants to merge 1 commit into
RT-Thread:masterfrom
cms19859230182-lang:fix/finsh-path-complete-bounds

Conversation

@cms19859230182-lang

Copy link
Copy Markdown
Contributor

中文

English

Fix RT-Thread#11839

In msh_auto_complete_path(), when the user inputs an excessively long
path string that exceeds DFS_PATH_MAX, attempting to concatenate and
resolve directory components in the fixed-size full_path buffer could
trigger a heap buffer overflow.

Check that the input path length does not exceed DFS_PATH_MAX before
allocating the buffer and attempting path resolution, aborting completion
safely when input is oversized.
@cms19859230182-lang

Copy link
Copy Markdown
Contributor Author

在 msh_auto_complete_path 入口增加了对输入路径长度的边界检查,超长时直接放弃补全,避免堆溢出风险。

@github-actions

Copy link
Copy Markdown

👋 感谢您对 RT-Thread 的贡献!Thank you for your contribution to RT-Thread!

为确保代码符合 RT-Thread 的编码规范,请在你的仓库中执行以下步骤运行代码格式化工作流(如果格式化CI运行失败)。
To ensure your code complies with RT-Thread's coding style, please run the code formatting workflow by following the steps below (If the formatting of CI fails to run).


🛠 操作步骤 | Steps

  1. 前往 Actions 页面 | Go to the Actions page
    点击进入工作流 → | Click to open workflow →

  2. 点击 Run workflow | Click Run workflow

  • Use workflow from 保持默认分支(通常为 master)
    Keep the default branch (usually master) in Use workflow from
  • 在 branch 输入框填写 PR 分支 fix/finsh-path-complete-bounds
    Enter PR branch fix/finsh-path-complete-bounds in the branch field
  • 设置需排除的文件/目录(目录请以"/"结尾)
    Set files/directories to exclude (directories should end with "/")
  1. 等待工作流完成 | Wait for the workflow to complete
    格式化后的代码将作为独立提交推送至你的分支。
    The formatting changes will be pushed to your branch as a separate commit.

完成后,提交将自动更新至 fix/finsh-path-complete-bounds 分支,关联的 Pull Request 也会同步更新。
Once completed, commits will be pushed to the fix/finsh-path-complete-bounds branch automatically, and the related Pull Request will be updated.

如有问题欢迎联系我们,再次感谢您的贡献!💐
If you have any questions, feel free to reach out. Thanks again for your contribution!

@github-actions

Copy link
Copy Markdown

📌 Code Review Assignment

🏷️ Tag: components

Reviewers: @Maihuanyi

Changed Files (Click to expand)
  • components/finsh/msh.c

📊 Current Review Status (Last Updated: 2026-11-14 19:18 CST)


📝 Review Instructions

  1. 维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
    Maintainers can refresh the review status by clicking here: 🔄 Refresh Status

  2. 确认审核通过后评论 LGTM/lgtm
    Comment LGTM/lgtm after confirming approval

  3. PR合并前需至少一位维护者确认
    PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。
ℹ️ Refresh CI status operation requires repository Write permission.

@github-actions

Copy link
Copy Markdown

MemBrowse Memory Report · Explore what changed →

k230

  • SRAM: .eh_frame -8 B (-0.0%, 1,391,448 B / 60,682,240 B, total: 2% used)

loongson-ls1cdev

  • Code: .text +32 B (+0.0%, 363,980 B)

nuvoton-m487

  • CODE: .text +16 B (+0.0%, 356,928 B / 524,288 B, total: 68% used)

qemu-virt64-aarch64

  • Code: .text +64 B (+0.0%, 1,011,260 B)

renesas-ra2l1

  • FLASH: .text +20 B (+0.0%, 98,512 B / 262,144 B, total: 38% used)

simulator

  • Code: .text +30 B (+0.0%, 2,676,684 B)

x86

  • Code: .text +16 B (+0.0%, 199,293 B)

No memory changes detected for:


Catch memory regressions in CI with MemBrowse. Free for open source.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Heap Buffer Overflow in FinSH msh_auto_complete_path via Oversized Input

1 participant