Repository navigation
model: keep all digits of Edm.Double values in literals and payloads - #332
Open
Shriraj1901 wants to merge 1 commit into
Open
Shriraj1901 wants to merge 1 commit into
Shriraj1901 wants to merge 1 commit into
Conversation
EdmFPNumTypTraits.to_literal formats every float with "{:E}", i.e. six
decimals, and to_json reuses it. A value such as 3.141592653589793 was
therefore sent as 3.141593E+00 in a $filter, in an entity key and in
the JSON body of a create or update request, so the service silently
stored or compared a different number.
Keep the current format whenever it reads back as the same float, so
the output for ordinary values is unchanged (2.029 is still
2.029000E+00), and only when it would change the value use the fewest
digits that round-trip.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EdmFPNumTypTraits.to_literal formats every float with "{:E}", i.e. six decimals, and to_json reuses it. A value such as 3.141592653589793 was therefore sent as 3.141593E+00 in a $filter, in an entity key and in the JSON body of a create or update request, so the service silently stored or compared a different number.
Keep the current format whenever it reads back as the same float, so the output for ordinary values is unchanged (2.029 is still 2.029000E+00), and only when it would change the value use the fewest digits that round-trip.