Skip to content

zigbee lock: move lock-without-codes out of legacy-handlers - #3374

Open
hcarter-775 wants to merge 1 commit into
mainfrom
zigbee-lock/move-lock-without-codes
Open

hcarter-775 wants to merge 1 commit into
mainfrom
zigbee-lock/move-lock-without-codes

Conversation

@hcarter-775

@hcarter-775 hcarter-775 commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Description of Change

These locks never support codes, so none of the legacy lockCodes handling applies to them. Promote the subdriver to the top level, along with its configurations.lua, and exclude its fingerprints from legacy-handlers so the two sibling subdrivers don't both handle it. Without this change, a newly onboarded lock from this subdriver would not utilize this subdriver, as it would be automatically migrated and thus would not use the legacy handling.

Testing Completed

No actual functionality has been changed, only the location in the pathing of the subdriver. All unit tests continue to pass.

These locks never support codes, so none of the legacy lockCodes
handling applies to them. Promote the subdriver to the top level,
along with its configurations.lua, and mark its devices as
SLGA_MIGRATED so legacy-handlers does not also handle them.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown

Test Results

   73 files    573 suites   0s ⏱️
3 480 tests 3 480 ✅ 0 💤 0 ❌
5 520 runs  5 520 ✅ 0 💤 0 ❌

Results for commit ed92d83.

@github-actions

Copy link
Copy Markdown

zigbee-lock_coverage.xml

File Coverage
All files 94% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-lock/src/lock-without-codes/configurations.lua 95% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-lock/src/legacy-handlers/init.lua 95% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-lock/src/legacy-handlers/migrate.lua 98% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-lock/src/samsungsds/init.lua 89% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-lock/src/lock_utils/tables.lua 98% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-lock/src/lock_utils/utils.lua 97% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-lock/src/lock_handlers/zigbee_responses.lua 86% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-lock/src/lock_handlers/capabilities.lua 89% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-lock/src/legacy-handlers/yale/init.lua 92% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-lock/src/init.lua 99% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-lock/src/lazy_load_subdriver.lua 57% ❌

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against ed92d83

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant