Repository navigation
zigbee lock: move lock-without-codes out of legacy-handlers - #3374
Open
hcarter-775 wants to merge 1 commit into
Open
hcarter-775 wants to merge 1 commit into
hcarter-775 wants to merge 1 commit into
Conversation
These locks never support codes, so none of the legacy lockCodes handling applies to them. Promote the subdriver to the top level, along with its configurations.lua, and mark its devices as SLGA_MIGRATED so legacy-handlers does not also handle them. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
hcarter-775
requested review from
NoahCornell,
cbaumler,
ctowns and
tpmanley
November 19, 2026 22:32
|
Invitation URL: |
Test Results 73 files 573 suites 0s ⏱️ Results for commit ed92d83. |
|
zigbee-lock_coverage.xml
Minimum allowed coverage is Generated by 🐒 cobertura-action against ed92d83 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
These locks never support codes, so none of the legacy lockCodes handling applies to them. Promote the subdriver to the top level, along with its
configurations.lua, and exclude its fingerprints from legacy-handlers so the two sibling subdrivers don't both handle it. Without this change, a newly onboarded lock from this subdriver would not utilize this subdriver, as it would be automatically migrated and thus would not use the legacy handling.Testing Completed
No actual functionality has been changed, only the location in the pathing of the subdriver. All unit tests continue to pass.