Skip to content

Fix hot-patch test path on Windows (#2080) #2082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Mikola Lysenko (mikolalysenko) wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix hot-patch test path on Windows (#2080) #2082

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ace90fd
Start hot-patch Windows test path fix
claude Nov 14, 2026
5fffc73
Compare hot-patch manifest paths as paths
claude Nov 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions crates/socket-patch-cli/src/hot_patch.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -619,14 +619,22 @@ mod tests {
};
assert!(!project.common.global);
assert_eq!(project.paths, ["packages/*"]);
assert_eq!(project.common.manifest_path, "/state/project/manifest.json");
// Compared as paths: the separator `Path::join` writes is the
// platform's, and a `/` in a literal is one on every platform.
assert_eq!(
Path::new(&project.common.manifest_path),
Path::new("/state/project/manifest.json")
);
// Go is the global pass's: a project run would rewrite `go.mod`.
assert!(!ecosystems(project).contains(&"golang"));
assert!(ecosystems(project).contains(&"npm"));
assert!(global.common.global);
assert!(global.paths.is_empty());
assert_eq!(global.common.ecosystems, None);
assert_eq!(global.common.manifest_path, "/state/global/manifest.json");
assert_eq!(
Path::new(&global.common.manifest_path),
Path::new("/state/global/manifest.json")
);
}

#[test]
Expand Down
Loading