Repository navigation
Fix subfolder files being copied into parent remote directories - #17
Merged
Merged
Conversation
SftpClient.SynchronizeDirectories enumerates recursively but uploads by file name only, so each parent remote directory received copies of all descendant files. Callers already visit every directory, so upload top-level files directly. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
During initial sync, files from subdirectories were also being uploaded into the remote root (and every ancestor directory), in addition to their correct target directories.
Cause
SftpClient.SynchronizeDirectoriesenumerates local files withSearchOption.AllDirectoriesbut uploads using only the file name. SFTPSync already calls it once per local directory, so each parent directory received flattened copies of all descendant files.Fix
SyncDirectoryAsyncnow uses a newUploadTopLevelFilesmethod inSFTPSyncLib/RemoteSync.csthat uploads only the files directly in each directory. Behaviour is otherwise the same: delete the remote file first, then upload with the same flags, with the same error wrapping. It also skips an unused remote directory listing. The SSH.NET submodule is unchanged.Testing
SFTPSyncLibbuilds with no warnings or errors.🤖 Generated with Claude Code