Repository navigation
Conversation
WriteGenericSTUNAttribute called V_memcpy with a null source pointer when writing a zero-length attribute (e.g. USE-CANDIDATE). memcpy with a null pointer is undefined behavior even when the count is 0. UBSan reports it as 'null pointer passed as argument 2, which is declared to never be null' on every nominated candidate pair. Only copy when the length is non-zero.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WriteGenericSTUNAttributecalledV_memcpywith a null source pointer when writing a zero-length attribute (e.g.USE-CANDIDATE, built withm_nLength = 0andm_pData = nullptr). Passing a null pointer tomemcpyis undefined behavior per the C standard even when the count is 0.*Verification
Built with
-DSANITIZE_ADDRESS=ON -DSANITIZE_UNDEFINED=ON, running the unmodifiedtest_p2p.py:strtools.h:47:116: runtime error: null pointer passed as argument 2, which is declared to never be nullfromWriteGenericSTUNAttribute→EncodeSTUNPacket→Think_TestPeerConnectivity, 26 times in one run (once per nominated candidate pair).test_cryptoandtest_p2p.py(TEST SUCCEEDED) pass on both builds.test_connection suite-quickaborts on an unrelated, pre-existing timing-sensitive assert that reproduces identically on unmodified master.*Source, technically this was UB on every nominated candidate pair, even though it never caused an observable crash on this platform.