Skip to content

Fix the Debug-only tests the HotKey change broke - #1053

Merged
SimonCropp merged 1 commit into
mainfrom
fix-hotkey-tests
Nov 16, 2026
Merged

SimonCropp merged 1 commit into
mainfrom
fix-hotkey-tests

Conversation

@SimonCropp

Copy link
Copy Markdown
Member

#1050 made HotKeyControl.HotKey into ReadHotKey() and ShowHotKey(), but HotKeyControlTests still set the property. It is in #if DEBUG, so the Release build and CI never compiled it.

OptionsFormTests, also Debug only, take .NET 11's drawing of the max instances up/down arrows, which are light where .NET 10 drew them dark; nothing else in the form moved.

In Debug: the solution builds, and DiffEngine.Tests, DiffEngineTray.Core.Tests and DiffEngineTray.Tests pass.

HotKeyControlTests set the control's HotKey property, which is ShowHotKey now; it is in #if DEBUG, so the Release build never compiled it. OptionsFormTests, also Debug only, take .NET 11's drawing of the up/down arrows, light where .NET 10 drew them dark.
@SimonCropp
SimonCropp merged commit beefa31 into main Nov 16, 2026
15 checks passed
@SimonCropp
SimonCropp deleted the fix-hotkey-tests branch November 16, 2026 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant