Repository navigation
Fix the Debug-only tests the HotKey change broke - #1053
Merged
Merged
Conversation
HotKeyControlTests set the control's HotKey property, which is ShowHotKey now; it is in #if DEBUG, so the Release build never compiled it. OptionsFormTests, also Debug only, take .NET 11's drawing of the up/down arrows, light where .NET 10 drew them dark.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1050 made
HotKeyControl.HotKeyintoReadHotKey()andShowHotKey(), butHotKeyControlTestsstill set the property. It is in#if DEBUG, so the Release build and CI never compiled it.OptionsFormTests, also Debug only, take .NET 11's drawing of the max instances up/down arrows, which are light where .NET 10 drew them dark; nothing else in the form moved.In Debug: the solution builds, and DiffEngine.Tests, DiffEngineTray.Core.Tests and DiffEngineTray.Tests pass.