Repository navigation
TypeGeneralizing: Handle exact casts without Custom Descriptors enabled - #9397
Merged
Merged
Conversation
tlively
approved these changes
Nov 16, 2026
tlively
left a comment
Member
There was a problem hiding this comment.
LGTM % comment on tests.
This would be fixed "for free" if TypeGeneralizing generalized casts. Is that on your near-term roadmap?
Comment on lines
+220
to
+221
| ;; enabled, $x generalizes to (ref $foo). Without custom descriptors, $x | ||
| ;; cannot become (ref (exact $foo)) (not a supertype of (ref (exact $bar))) |
Member
There was a problem hiding this comment.
This makes it sound like generalizing to (ref (exact $foo)) is something we would want to do if we could, but of course that would never be correct. Let's drop or reword that part of the comment.
Member
Author
Hmm, I hadn't been thinking about that. My immediate goal is just to fuzz this and get it ready for use. But I'll take a look at casts after, thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without CD, only trivial exact casts are allowed, so we must be
carefully to not make trivial ones non-trivial.