Skip to content

Build/Test Tools: Update @types/node to 24.19.2. - #16045

Draft
desrosj wants to merge 1 commit into
WordPress:trunkfrom
desrosj:update/types-node-24
Draft

desrosj wants to merge 1 commit into
WordPress:trunkfrom
desrosj:update/types-node-24

Conversation

@desrosj

@desrosj desrosj commented Nov 16, 2026

Copy link
Copy Markdown
Member

Updates @types/node from 20.19.43 to 24.19.2, so the type definitions match the Node.js 24 version Core requires (>=24.18.0). It was added while Core still targeted Node.js 20, and wasn't updated when Core moved to Node.js 24.

  • Only npm run typecheck:js uses it, and that passes.
  • The npm run build output is unchanged and matches WordPress/WordPress r65536.

@wordpress/e2e-test-utils-playwright 1.x declares a ^20.17.10 peer dependency on @types/node, so npm ls now flags it as invalid. legacy-peer-deps is enabled, so installs aren't affected, and it is only used for types. It is fixed in 2.0.0 and later. I left that update out of this PR because @wordpress/scripts 33.0.0 depends on 1.x, so updating it alone installs a second copy of the package. The two should be updated together, to the versions used by the pinned Gutenberg version (@wordpress/scripts 37.0.0, @wordpress/e2e-test-utils-playwright 3.1.0).

Trac ticket: https://core.trac.wordpress.org/ticket/65857

Use of AI Tools

AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5.5
Used for: Reviewing the upstream changes, applying and testing the update, and drafting the commit message and this description. I reviewed the changes.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

🤖 Generated with Claude Code

https://claude.ai/code/session_011Y86h1C6BoWy65W2SSqvtD

Update `@types/node` from `20.19.43` to `24.19.2`, along with its `undici-types` dependency, so the type definitions match the Node.js 24 version that Core requires.

See #65857.

Claude-Session: https://claude.ai/code/session_011Y86h1C6BoWy65W2SSqvtD
@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant