Repository navigation
Conversation
Update `@types/node` from `20.19.43` to `24.19.2`, along with its `undici-types` dependency, so the type definitions match the Node.js 24 version that Core requires. See #65857. Claude-Session: https://claude.ai/code/session_011Y86h1C6BoWy65W2SSqvtD
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates
@types/nodefrom 20.19.43 to 24.19.2, so the type definitions match the Node.js 24 version Core requires (>=24.18.0). It was added while Core still targeted Node.js 20, and wasn't updated when Core moved to Node.js 24.npm run typecheck:jsuses it, and that passes.npm run buildoutput is unchanged and matches WordPress/WordPress r65536.@wordpress/e2e-test-utils-playwright1.x declares a^20.17.10peer dependency on@types/node, sonpm lsnow flags it as invalid.legacy-peer-depsis enabled, so installs aren't affected, and it is only used for types. It is fixed in 2.0.0 and later. I left that update out of this PR because@wordpress/scripts33.0.0 depends on 1.x, so updating it alone installs a second copy of the package. The two should be updated together, to the versions used by the pinned Gutenberg version (@wordpress/scripts37.0.0,@wordpress/e2e-test-utils-playwright3.1.0).Trac ticket: https://core.trac.wordpress.org/ticket/65857
Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5.5
Used for: Reviewing the upstream changes, applying and testing the update, and drafting the commit message and this description. I reviewed the changes.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.
🤖 Generated with Claude Code
https://claude.ai/code/session_011Y86h1C6BoWy65W2SSqvtD