Skip to content

GH-47465: [C++] Mark the glog backend for deprecation - #55632

Open
atharva-potdar wants to merge 4 commits into
apache:mainfrom
atharva-potdar:gh-47465-deprecate-glog
Open

atharva-potdar wants to merge 4 commits into
apache:mainfrom
atharva-potdar:gh-47465-deprecate-glog

Conversation

@atharva-potdar

@atharva-potdar atharva-potdar commented Nov 16, 2026 •

Copy link
Copy Markdown

Rationale for this change

As discussed in GH-47465, glog is no longer maintained, therefore this PR deprecates the glog backend in Apache Arrow.

What changes are included in this PR?

  • Mark ARROW_USE_GLOG CMake option as deprecated and emit a warning for it
  • Mark GLOG as deprecated in the C++ build docs
  • Deprecate ArrowLog::InstallFailureSignalHandler() and ArrowLog::UninstallSignalAction() and suppress the deprecation warnings for their calls in acero_main.cc and test_integration_client.cc

Are these changes tested?

Yes, I tested them locally with CMake/Ninja.

Are there any user-facing changes?

Yes, ARROW_USE_GLOG, ArrowLog::InstallFailureSignalHandler() and UninstallSignalAction() now emit deprecation warnings.

Was AI used for this PR?

Yes, Copilot's code review caught a macro for deprecation that I hadn't used. I accepted its suggestion, and the commit that added it has Copilot as a co-author.

PR code and description written by:

  • Human
  • AI

Reviewed before submission by:

  • Human
  • AI
  • Not reviewed

Copilot AI lite review requested due to automatic review settings November 16, 2026 11:19
@github-actions

Copy link
Copy Markdown

⚠️ GitHub issue #47465 has been automatically assigned in GitHub to PR creator.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The new deprecation annotations are Doxygen-only, so downstream C++ callers will not receive the promised compiler warnings until the declarations use ARROW_DEPRECATED.

1 open issue
What changed in this PR

This PR deprecates Apache Arrow’s C++ glog integration and related signal-handler APIs because glog is no longer maintained.

Changes:

  • Marks ARROW_USE_GLOG and the GLOG dependency as deprecated.
  • Documents deprecation of the ArrowLog signal-handler APIs.
  • Removes deprecated signal-handler calls from Flight SQL and integration-test code.
File Description
docs/​source/​developers/​cpp/​building.rst Marks the GLOG dependency as deprecated in the C++ build documentation.
cpp/​src/​arrow/​util/​logging.h Documents the deprecation of the ArrowLog signal-handler APIs.
cpp/​src/​arrow/​util/​logging.cc Suppresses deprecation warnings around the signal-handler implementations.
cpp/​src/​arrow/​flight/​sql/​example/​acero_main.cc Removes the deprecated failure signal-handler call.
cpp/​src/​arrow/​flight/​integration_tests/​test_integration_client.cc Removes deprecated signal-handler installation and cleanup calls.
cpp/​cmake_modules/​DefineOptions.cmake Marks ARROW_USE_GLOG as deprecated and adds a configuration warning when it is enabled.

Review effort: Lite

Comment thread cpp/src/arrow/util/logging.h Resolved
Copilot AI lite review requested due to automatic review settings November 16, 2026 11:24

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No outstanding issues are identified, and the deprecated glog and signal-handler usage is consistently annotated or removed across the documented changes.

No open issues 🎉

1 resolved since last review

Review effort: Lite

@lidavidm
lidavidm requested a review from pitrou November 16, 2026 23:43
}

int main(int argc, char** argv) {
arrow::util::ArrowLog::InstallFailureSignalHandler();

@pitrou pitrou Nov 17, 2026 •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not keep this and other calls to deprecated APIs, while enclosing them in ARROW_SUPPRESS_DEPRECATION_WARNING ?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean wrap every call of this API in ARROW_SUPPRESS_DEPRECATION_WARNING rather than removing the function entirely? That works, I'll create a commit for it

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we'll just remove the API calls when we actually remove the deprecated APIs.

@atharva-potdar
atharva-potdar force-pushed the gh-47465-deprecate-glog branch from ac12863 to 3ced9f9 Compare November 17, 2026 08:48
Copilot AI lite review requested due to automatic review settings November 17, 2026 08:48

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are reported, and the changes consistently document and suppress expected deprecation warnings while preserving existing call sites.

No open issues 🎉

Review effort: Lite

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants