Repository navigation
GH-47465: [C++] Mark the glog backend for deprecation - #55632
atharva-potdar wants to merge 4 commits into
Conversation
|
|
There was a problem hiding this comment.
🟡 Changes recommended
The new deprecation annotations are Doxygen-only, so downstream C++ callers will not receive the promised compiler warnings until the declarations use ARROW_DEPRECATED.
1 open issue
What changed in this PR
This PR deprecates Apache Arrow’s C++ glog integration and related signal-handler APIs because glog is no longer maintained.
Changes:
- Marks
ARROW_USE_GLOGand theGLOGdependency as deprecated. - Documents deprecation of the
ArrowLogsignal-handler APIs. - Removes deprecated signal-handler calls from Flight SQL and integration-test code.
| File | Description |
|---|---|
| docs/source/developers/cpp/building.rst | Marks the GLOG dependency as deprecated in the C++ build documentation. |
| cpp/src/arrow/util/logging.h | Documents the deprecation of the ArrowLog signal-handler APIs. |
| cpp/src/arrow/util/logging.cc | Suppresses deprecation warnings around the signal-handler implementations. |
| cpp/src/arrow/flight/sql/example/acero_main.cc | Removes the deprecated failure signal-handler call. |
| cpp/src/arrow/flight/integration_tests/test_integration_client.cc | Removes deprecated signal-handler installation and cleanup calls. |
| cpp/cmake_modules/DefineOptions.cmake | Marks ARROW_USE_GLOG as deprecated and adds a configuration warning when it is enabled. |
Review effort: Lite
| } | ||
|
|
||
| int main(int argc, char** argv) { | ||
| arrow::util::ArrowLog::InstallFailureSignalHandler(); |
There was a problem hiding this comment.
Why not keep this and other calls to deprecated APIs, while enclosing them in ARROW_SUPPRESS_DEPRECATION_WARNING ?
There was a problem hiding this comment.
You mean wrap every call of this API in ARROW_SUPPRESS_DEPRECATION_WARNING rather than removing the function entirely? That works, I'll create a commit for it
There was a problem hiding this comment.
Yes, we'll just remove the API calls when we actually remove the deprecated APIs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
ac12863 to
3ced9f9
Compare
3ced9f9 to
72990e2
Compare

Rationale for this change
As discussed in GH-47465, glog is no longer maintained, therefore this PR deprecates the glog backend in Apache Arrow.
What changes are included in this PR?
ARROW_USE_GLOGCMake option as deprecated and emit a warning for itGLOGas deprecated in the C++ build docsArrowLog::InstallFailureSignalHandler()andArrowLog::UninstallSignalAction()and suppress the deprecation warnings for their calls inacero_main.ccandtest_integration_client.ccAre these changes tested?
Yes, I tested them locally with CMake/Ninja.
Are there any user-facing changes?
Yes,
ARROW_USE_GLOG,ArrowLog::InstallFailureSignalHandler()andUninstallSignalAction()now emit deprecation warnings.Was AI used for this PR?
Yes, Copilot's code review caught a macro for deprecation that I hadn't used. I accepted its suggestion, and the commit that added it has Copilot as a co-author.
PR code and description written by:
Reviewed before submission by: