Repository navigation
mod_deflate: Keep the response Content-Encoding with the input filter - #1052
Open
arturobernalg wants to merge 1 commit into
Open
arturobernalg wants to merge 1 commit into
arturobernalg wants to merge 1 commit into
Conversation
check_gzip() syncs r->content_encoding with the Content-Encoding of the headers it was given. That is meant for the response headers of the output filters, but the input filter passes r->headers_in, so the response's Content-Encoding (e.g. from AddEncoding) was replaced by the request's, which is usually none. Only sync it for the response headers. PR 66149.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bz.apache.org/bugzilla/show_bug.cgi?id=66149
With
SetInputFilter DEFLATE, a response loses the Content-Encoding set for it, e.g. byAddEncoding x-gzip .gz.check_gzip() syncs r->content_encoding with the Content-Encoding of the headers it is given. That is meant for the output filters, which pass the response headers. The input filter passes r->headers_in, so the response's encoding was replaced by the request's, usually none. It runs on any GET, since the default handler discards the request body through the input filters.
The sync is now done only for the response headers. A gzipped request body is still inflated as before.
Test: test_filters_009_03 in test/modules/filters/test_009_mod_deflate.py, with and without a gzipped request body. It fails on trunk and passes with the fix; the filters suite passes (104).
(see
SECURITY.mdandhttps://www.apache.org/security/#reporting-a-vulnerability).
APLOGNO()tag;numbers are assigned by a committer at merge time (see
docs/log-message-tags/README).changes-entries/*.txtfile is included,following the template in
README.CHANGES(not needed otherwise).test/modules/xxxdirectory matching themodules/xxxmodule source,or
test/modules/corefor core server changes. On Unix, verify thesepass locally with e.g.
make check-pytest PYTEST_DIRS=test/modules/xxx.