Repository navigation
mod_cache: Do not store/serve a response whose Vary contains '*'. - #958
Open
arturobernalg wants to merge 1 commit into
Open
arturobernalg wants to merge 1 commit into
arturobernalg wants to merge 1 commit into
Conversation
4 of 5 tasks
The cacheability check for Vary: * only looked at r->headers_out, so a Vary: * set via "Header always" (which writes to r->err_headers_out) was missed, even though storage itself merges err_headers_out in via cache_merge_headers_out(). This let a response meant for one client be cached and served back to a different client. Also guard the read side: per RFC 9111 4.1, a stored response with a Vary value containing the member '*' always fails to match, since '*' is not a real request-header name to compare against. PR 70289
arturobernalg
force-pushed
the
fix/httpd-70289-trunk-vary-star
branch
from
November 18, 2026 15:00
031d864 to
6409ab6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cacheability check for Vary: * only looked at r->headers_out, so a Vary: * set via "Header always" (which writes to r->err_headers_out) was missed, even though storage itself merges err_headers_out in via cache_merge_headers_out(). This let a response meant for one client be cached and served back to a different client.
Also guards the read side: per RFC 9111 4.1, a stored response with a Vary value containing the member '' always fails to match, since '' is not a real request-header name to compare against.
This is the trunk port of the fix already merged to 2.4.x in #909, which was missed on trunk at the time.
BZ: https://bz.apache.org/bugzilla/show_bug.cgi?id=70289
(see
SECURITY.mdandhttps://www.apache.org/security/#reporting-a-vulnerability).
APLOGNO()tag;numbers are assigned by a committer at merge time (see
docs/log-message-tags/README).changes-entries/*.txtfile is included,following the template in
README.CHANGES(not needed otherwise).test/modules/xxxdirectory matching themodules/xxxmodule source,or
test/modules/corefor core server changes. On Unix, verify thesepass locally with e.g.
make check-pytest PYTEST_DIRS=test/modules/xxx.