Skip to content

mod_cache: Do not store/serve a response whose Vary contains '*'. - #958

Open
arturobernalg wants to merge 1 commit into
apache:trunkfrom
arturobernalg:fix/httpd-70289-trunk-vary-star
Open

arturobernalg wants to merge 1 commit into
apache:trunkfrom
arturobernalg:fix/httpd-70289-trunk-vary-star

Conversation

@arturobernalg

Copy link
Copy Markdown
Member

The cacheability check for Vary: * only looked at r->headers_out, so a Vary: * set via "Header always" (which writes to r->err_headers_out) was missed, even though storage itself merges err_headers_out in via cache_merge_headers_out(). This let a response meant for one client be cached and served back to a different client.

Also guards the read side: per RFC 9111 4.1, a stored response with a Vary value containing the member '' always fails to match, since '' is not a real request-header name to compare against.

This is the trunk port of the fix already merged to 2.4.x in #909, which was missed on trunk at the time.

BZ: https://bz.apache.org/bugzilla/show_bug.cgi?id=70289


  • This PR does not report or address a security vulnerability
    (see SECURITY.md and
    https://www.apache.org/security/#reporting-a-vulnerability).
  • Code follows the httpd style guide.
  • New log messages (level debug or higher) use an empty APLOGNO() tag;
    numbers are assigned by a committer at merge time (see docs/log-message-tags/README).
  • If the change is user-visible, a changes-entries/*.txt file is included,
    following the template in README.CHANGES (not needed otherwise).
  • Test cases based on pyhttpd are included where appropriate, in the
    test/modules/xxx directory matching the modules/xxx module source,
    or test/modules/core for core server changes. On Unix, verify these
    pass locally with e.g. make check-pytest PYTEST_DIRS=test/modules/xxx.

The cacheability check for Vary: * only looked at r->headers_out, so a
Vary: * set via "Header always" (which writes to r->err_headers_out)
was missed, even though storage itself merges err_headers_out in via
cache_merge_headers_out(). This let a response meant for one client be
cached and served back to a different client.

Also guard the read side: per RFC 9111 4.1, a stored response with a
Vary value containing the member '*' always fails to match, since '*'
is not a real request-header name to compare against.

PR 70289
@arturobernalg
arturobernalg force-pushed the fix/httpd-70289-trunk-vary-star branch from 031d864 to 6409ab6 Compare November 18, 2026 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant