Repository navigation
[Docs] Fix two stale notes in iotdb-system.properties.template - #19320
Open
farisbasha wants to merge 1 commit into
Open
farisbasha wants to merge 1 commit into
farisbasha wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Two comments in
iotdb-core/node-commons/src/assembly/resources/conf/iotdb-system.properties.templatecontradict the code and the value written right below them.enable_auto_leader_balance_for_ratis_consensusThe comment says
Notice: Default is false because the Ratis is unstable for this function., but the template setsenable_auto_leader_balance_for_ratis_consensus=true, and the code default is alsotrue:ConfigNodeConfig.java:private boolean enableAutoLeaderBalanceForRatisConsensus = true;ConfigNodeDescriptor.javareads the key withString.valueOf(conf.isEnableAutoLeaderBalanceForRatisConsensus())as the fallback.A user reading the template is told the feature is off by default when it is on. The stale notice line is removed; the rest of the comment is unchanged.
max_expired_timeThe comment says
Datatype: int, but the value is2592000000(30 days in ms), which is larger thanInteger.MAX_VALUE(2147483647). The code stores it aslong maxExpiredTime = 2_592_000_000L(IoTDBConfig.java) and parses it withLong.parseLong(IoTDBDescriptor.java). The datatype is changed tolong.Comment-only change in the configuration template; no code or default value changes.
Key changed/added classes (or packages if there are too many classes) in this PR
iotdb-system.properties.template(comments only)This was found with the help of an AI assistant.