Skip to content

Delete partial file when local download_object_range fails (#2223) - #2227

Open
raamrutsagarb25-tech wants to merge 1 commit into
apache:trunkfrom
raamrutsagarb25-tech:fix-local-range-download-cleanup
Open

raamrutsagarb25-tech wants to merge 1 commit into
apache:trunkfrom
raamrutsagarb25-tech:fix-local-range-download-cleanup

Conversation

@raamrutsagarb25-tech

Copy link
Copy Markdown

Changes Title (replace this with a logical title for your changes)

Description

Replace this with the PR description (mention the changes you have made, why
you have made them, provide some background and any references to the provider
documentation if needed, etc.).

For more information on contributing, please see Contributing
section of our documentation.

Status

Replace this: describe the PR status. Examples:

  • work in progress
  • done, ready for review

Checklist (tick everything that applies)

  • Code linting (required, can be done after the PR checks)
  • Documentation
  • Tests
  • ICLA (required for bigger changes)

@raamrutsagarb25-tech

Copy link
Copy Markdown
Author

Hi, I've opened a pull request for this: <#2227 >

download_object_range in the local storage driver now removes the partially written file when reading the source fails and delete_on_failure=True. I also added a test and a changelog entry. Happy to make any changes you'd like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant