Repository navigation
Conversation
Omit Cmd when command is None and preserve explicit command strings. Add regression coverage for omitted, empty and quoted commands. Refs apache#2226
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2226.
DockerContainerDriver.deploy_container()currently converts an omitted command into['None'], overriding the image's default command.This change omits
CmdwhencommandisNone, while preserving the existing parsing behavior for explicitly supplied command strings.Regression tests cover omitted commands, explicit
None, empty strings, whitespace and quoted arguments using the existing Linux and macOS Docker mock fixtures.Status
Ready for review.
Validation performed in the [fork CI](https://github.com/fbccsz/libcloud/actions/runs/43597390983):
No new dependencies or CI configuration changes.
Checklist