Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Require
appium_lib_core >= 14.0.0, < 15.0and adapt driver initialization and screenshot helpers to APIs supported by core 14. Preserve the wrapper'sappium_lib[:wait],default_wait,no_wait,set_wait, and screenshot helpers, including applying a configured implicit wait after each session starts.Breaking changes:
waitandwait_truenow retry onlyNoSuchElementErrorby default. For example,wait { assert_equal ... }now propagates an assertion failure immediately unlessMinitest::Assertionis explicitly included inignored:. Core APIs such asAppium.symbolize_keysandElement#location_relare no longer available. This change should ship in a major release.Document migration steps and assertion-retry examples in the CHANGELOG and wait helper docstrings. Update Android/iOS test expectations for core 14 and add regression coverage for option handling, implicit waits, screenshots, and wait exception behavior.
How Has This Been Tested?
bundle exec rake testwith core 14.0.0: 53 tests, 143 assertions, no failures or errors.bundle exec rake rubocop: 103 files, no offenses.git diff --checkafter the docstring examples were added.Checklist
bundle exec rake rubocop