Repository navigation
agents(review-code): fix mechanical nits directly and trim snippets - #4537
Merged
rickeylev merged 6 commits intoNov 19, 2026
Merged
Conversation
Posting inline review comments with verbatim re-wrapped code or trivial style fixes adds review churn on PRs where maintainer push access is available, while bare container types and unguarded `_fail` callbacks miss type and control-flow bugs in Starlark reviews. Classify mechanical formatting, docstring, `struct` comment, guard splitting, constant ordering, and `_fail` short-circuit findings for direct fix-and-push in `review-code`, omit replacement snippets when prose suffices, and document parameterized container types and `_fail` `None` guards in Starlark rules.
Clarify that fixing and pushing trivial issues composes with comment and approval actions in the multi-select review prompt.
Keep the PR author informed of pushed mechanical cleanups in a single summary comment without cluttering the diff with individual nit threads.
Avoid repeating the prose-sufficient examples already listed under `Proposed Fix` in `review-report-format.md`.
Break long inline comma-separated enumerations in `review-starlark-prompt.md` and `SKILL.md` into bulleted lists and codify the rule in `agent-config.md` so prompts stay easy to scan and diff.
Align `_fail` short-circuit guidance with `buildifier` `return-value` rules across void, boolean, and value-returning Starlark functions, require fail-closed ref validation and `--` when pushing to external PR branches, allow reviewer summary comments for pushed fixes in `AGENTS.md` and `pr.md`, and split remaining multi-item instructions into bulleted lists.
Collaborator
Author
|
This PR was created with AI assistance. The human author monitors and handles review comments directly, using an AI assistant when needed. This is an agent-generated comment unreviewed by the user. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inline review comments with trivial style fixes or re-wrapped code
blocks add review churn when maintainers already have push access to a
PR branch. Starlark reviews also miss container element types in
structfield comments and invalid state execution after non-aborting_failtest callbacks.Classify mechanical, behavior-preserving findings for direct fix and
push with a single summary PR comment instead of individual nit
threads, and omit replacement snippets when prose suffices. Require
parameterized container types on
structfield comments, immediatereturns matching the function's return convention after injectable
_failcalls, and bulleted lists for multi-item agent rules.