Repository navigation
Conversation
Keep parser failures separate from callback exceptions. Add split-packet, Client/Pool rejection and subsequent-connection regression coverage. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Handle binary PostgreSQL GSS negotiation with the optional Kerberos binding, protect context completion and cancellation, and keep GSS transport encryption unsupported. Add real-fixture and protocol/lifecycle tests and document the driver boundary. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Register each protocol regression once and ensure failed fixture teardown cannot report a passing check. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Treat writable-stream backpressure as an accepted authentication token. Ignore readiness after a failed or destroyed connection, and keep application connect callback/listener exceptions outside authentication promise catches. Add whole-Client and Pool regressions for all three boundaries. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
hacetin
marked this pull request as ready for review
November 19, 2026 10:51
Author
|
Related to #3267, which introduces GSS authentication codes 7/8, optional Parser-failure containment also overlaps #3843. |
Author
|
@brianc @charmander PTAL |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add ticket-based authentication to the existing JavaScript driver through the
optional
kerberosnative binding. Ordinary password connections do not loadthe binding.
opaque binary tokens and framing responses without a C-string terminator.
connect()only after the client context completes and the server acceptsauthentication and reports readiness. Suppress late results after cancellation.
connections, with platform-appropriate service identities.
while preserving application callback exceptions.
disposable Linux PostgreSQL/Kerberos/TLS/SSH fixture.
GSS transport encryption is not implemented.
gssencmode=requirerejects beforeopening a socket;
preferdoes not enable encryption. TLS verification is notweakened. This does not add credential delegation, automatic password fallback,
or a switch to another driver.
Validation
Final source:
e8bc50dfdda975fff0be63911ddf72d751ff063e.The Windows unit failures concern existing
USER/USERNAMEassumptions andlocalhost DNS after a test clears the process environment. They were not hidden
or repaired as part of this change.
Seven focused regressions reproduce three defects in the initial candidate:
misinterpreted stream backpressure, readiness overriding an authentication
failure, and application connect exceptions being misclassified as authentication
errors. All seven pass with the final fixes.
The 65,535-byte token limit, rejection above that limit, copied-token ownership
and exact binary response framing were also checked.
Qualification boundaries
Earlier real PostgreSQL/Kerberos evidence belongs to the source tree at
9cad6da07e7d4063b0e4f65108ee7c6a8933a379, not a new real-Kerberos run on thefinal follow-up commit. Only public commit-attribution metadata changed when
preparing that source for publication; the tested source tree is identical.
That candidate passed real Linux Kerberos and direct Windows-domain
GSS/Kerberos checks.
Windows SSPI client Kerberos was exercised through an explicitly labeled
AuthenticationGSS-to-AuthenticationSSPI request-code adapter backed by real
PostgreSQL/SPNEGO/KDC and verified TLS. This is not a native Windows-server
SSPI/Kerberos interoperability pass; local native-server SSPI negotiated NTLM.
SSPI success alone must not be described as proof of Kerberos.
Actual VS Code extension-host Kerberos qualification remains incomplete:
the new attempts hit the unmodified startup-readiness guard. Bundled Node
success is not an actual extension-host pass. macOS, ARM, Node 16 execution and
signed native-binary distribution are also unqualified.
This draft is for scoped experimental review, not a claim of production-ready
or complete cross-platform Kerberos support.