Skip to content

Skip earlier vregs' blockparam inputs when placing moves - #281

Merged
cfallin merged 1 commit into
bytecodealliance:mainfrom
kestred:placing-moves
Nov 17, 2026
Merged

cfallin merged 1 commit into
bytecodealliance:mainfrom
kestred:placing-moves

Conversation

@kestred

@kestred kestred commented Nov 17, 2026

Copy link
Copy Markdown
Contributor

Fixes #274.

apply_allocations_and_insert_moves resumes its walk of blockparam_ins from a cursor left by the previous vreg, but
PrevBuffer moves the cursor only when a later range starts. A vreg with one range leaves it in place, and every
following vreg rescans those entries. This skips the entries of earlier vregs, and corrects the sort order in the
comment above.

My ordinary test corpus (~20 programs of various shapes) compile time is unchanged.

For pathological programs, register allocation time with N loops in a row:

Loops Before After
1,024 110 ms 18 ms
4,096 1.92 s 87 ms

@cfallin cfallin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cfallin
cfallin merged commit 4eb655f into bytecodealliance:main Nov 17, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

perf: placing moves takes quadratic time in the number of blocks

2 participants