Repository navigation
Conversation
…apshot The tree tier read the viewport after the root snapshot through a live app.windows resolution. Each of its reads (the window list, exists, frame) snapshots the whole app again: on a heavy web view they took 7.4 s, ran past the viewport's 1 s slice, discarded the completed tree capture, and left main-thread work that refused the next tap with RUNNER_BUSY. When AXRuntime reports the target as the primary app filling the screen and the snapshot's first usable window is exactly that screen at the origin, the viewport is that window's frame. A placed iPad window, an offset window, and a landscape window keep the live read, since a snapshot frame is in window content space.
…iewport in its test
|
Thanks, this is ready at 4836a66. The change reads correctly, and all 14 checks pass at this head. There are no conflicts. Nothing else must happen before merge. Not blocking, and you can take or leave these: the comment above the snapshot_viewport hop in RunnerTests+SnapshotAcquisition.swift still says the viewport and the orientation are read in one hop, but on the full-screen path the box now comes from the root snapshot and only the orientation is read live; The 7.4 s measurement and the 1/4 vs 4/4 repro table are author-reported, with no attached logs. No live run covers an iPad full-screen app, which now takes the snapshot path. The exact-equality guard keeps that safe, because any frame mismatch falls back to the live read. |
Address review: the AXRuntime probe now runs only once a usable window is found, the viewport hop comment names the snapshot box, and the regression test fails instead of skipping on an iPhone.
|
Thanks. All three are in 69f7fe4:
The three affected tests pass on an iPhone 17 Pro simulator (iOS 26.5). The iOS, macOS, and tvOS runners build, and |
|
This PR is ready from my review at 69f7fe4. The three notes from the earlier review (4836a66) are fixed: the stale one-hop comment, the probe running without a usable window, and the test that skipped when the predicate was nil. I found no new problems in the delta. Not blocking: The earlier review comment above still applies: all three of its notes are fixed at this head, so that thread can be resolved. The simulator results in your comment, the 7.4 s measurement and the repro table are author-reported, and no live iPad or landscape run covers the placed-window and landscape fallbacks. The pure predicate test covers both. CI is green apart from one job still running, and the earlier head passed all 14 checks. There are no conflicts, and nothing else blocks merge. |
Summary
On a full-screen iOS app with a heavy screen, a tap right after a snapshot fails with
RUNNER_BUSY. The tree tier read the viewport through a liveapp.windowsresolution. Each of its reads snapshots the whole app again. On a 3,000-linkWKWebViewthey took 7.4 s. That overran the 1 s slice, discarded the finished tree, and left main-thread work that refused the next tap.A full-screen window at the origin (the #4573 rule, now one predicate) now takes its viewport from the root snapshot. Snapshot frames are in window content space. So placed iPad windows, offset windows, landscape, lit panels, and non-iOS keep the live read.
5 files: runner Swift, two runner tests, runner README.
Validation
Head
4836a661bon main945b1f0d0. iPhone 17 Pro simulator, iOS 26.5, gronxb/e2e-repro./repro.sh:snapshot_viewportabandonedRUNNER_BUSYtapseddad1abc: 748 tests run. The 5 failing landscape tests fail identically on main (the host app does not rotate).check:xctest-selectionpasses.check:affected --run --head 4836a661b: onlyunitfails, oneager-closure-budgets(Android). It fails on main too.Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.