Repository navigation
Conversation
|
I reviewed 6e1b790 and found one change to make before merge. The RPC-first stop route itself looks well owned.
Not blocking, take or leave: The only reported check was skipped, so nothing yet attributes a pass or failure to this head. The full CI, including the Linux/macOS suites, |
|
Thanks @thymikee for the review — addressed the blocking issue and the follow-ups in
Could a maintainer approve the fork CI run for |
|
This PR is ready at b04b6bb. The findings from the earlier review (6e1b790, #4659 (comment)) are fixed, and I found nothing new that needs a change. Not blocking, and you can take or leave these: readReusableLocalDaemon passes settings.host for every non-reuse decision, including an unreachable daemon, so a TCP-hung daemon waits out the 2s RPC timeout and the 3s term window before SIGKILL (https://github.com/callstack/agent-device/blob/b04b6bb/packages/daemon-client/src/daemon-client-startup.ts#L146); passing host only when decision.cause is not unreachable would match the rule in your stopDaemonForTakeover comment. The new No checks have reported on b04b6bb yet because fork CI is waiting for maintainer approval. The new tests, wire-compat and layering gates have not run yet, and the Windows results rest on your report. A maintainer needs to approve the CI run so the full suites, wire-compat and layering gates can run before merge. There are no conflicts. |
Summary
daemon_shutdownRPC admission (packages/daemon/src/sessions/server/daemon-idle-reap.ts) that reusesquiesceauth,publicNetworkOnly,pid/processStartTimefence,embeddedrefusal, andstartingUpguard while draining active sessions and retained leases.'shutdown'toDAEMON_CAPABILITIES(packages/daemon-contracts/src/daemon-resolution.ts) with acompatibleChangesentry intest/wire-compat/ledger.json.createGracefulDaemonShutdownthroughstopRecordedDaemon(parsing rawDaemonStopIdentity.recordviaparseDaemonInfo),cleanupDaemonAfterRequest, andreadReusableLocalDaemon->stopDaemonForTakeover, mappingtimeoutto'accepted'so slow drains waittermTimeoutMsbeforeSIGKILL(SIGTERMWin32 fallback markedforced).SIGTERMterminates the process before retained leases finalize).Validation
Verified locally on Windows 11 (
b04b6bb31):pnpm build,pnpm check:quick,scripts/layering/check.ts,scripts/di-seams/check.ts,pnpm check:production-exports,scripts/wire-compat/run.ts: passed.smoke-daemon-http.test.ts+smoke-daemon-clean.test.ts: 4/4 passed.16daemon/contracts/client/CLI/host files): 178/178 passed; local WebDriver mock E2E + old-daemon compat passed.pnpm check:affected --run, and native device lanes (3 unrelated daemon test files fail locally on Windows due to pre-existing POSIXchmod/SIGTERM/quoting assumptions, andwin32branches rely on mocks where noted).