Skip to content

fix(fab): honour reduceMotion="off" over the device setting - #5231

Merged
Doberjohn merged 2 commits into
mainfrom
@Doberjohn/fab-reduce-motion
Nov 18, 2026
Merged

Doberjohn merged 2 commits into
mainfrom
@Doberjohn/fab-reduce-motion

Conversation

@Doberjohn

Copy link
Copy Markdown
Collaborator

Motivation

<PaperProvider reduceMotion="off"> should keep animations on when the device asks for less motion. Checkbox and Switch pass an explicit Reanimated reduceMotion; FAB, FAB.Extended and FAB.Menu didn't, so Reanimated followed the device and snapped them. Their springs now pass ReduceMotion.Never when Paper allows motion.

Related issue

None.

Screenshots / Videos

None: only visible with the device setting on and reduceMotion="off".

Test plan

  • yarn test covers the spring configs.
  • iOS 27.2, Android 13, web, with the device setting on and reduceMotion="off": the FAB animates; on main it snaps.

FAB, FAB.Extended and FAB.Menu called withSpring without a reduceMotion
config, so Reanimated followed the device setting and snapped them even
when PaperProvider allowed motion. Pass ReduceMotion.Never when Paper's
preference allows motion, as Checkbox and Switch do.
@github-actions

Copy link
Copy Markdown

Found potential problems with the pull request:

  • Screenshot or video evidence is missing. Make sure to include one if it affects the UI.

@apex-sentinel-staging

This comment has been minimized.

@apex-sentinel-staging

Copy link
Copy Markdown

Apex Sentinel · ✅ Approve · review of 7fd6e3e

Since the review of 2d27e52: 0 new · 0 still open · 0 no longer raised

No open findings.

Reviewed with this repository's own Sentinel configuration (86430de2a63e).

💬 Talking to Sentinel

In a finding's thread, reply with:

Command What it does
@apex-sentinel-staging note <context> Adds context; Sentinel re-checks the cited code
@apex-sentinel-staging pivot <why> Says the finding is wrong; Sentinel re-checks the cited code
@apex-sentinel-staging like Marks the finding as useful
@apex-sentinel-staging dislike <why> Marks it as not useful, so it is not raised again

On this conversation, comment @apex-sentinel-staging review to run a full review once again.

@Doberjohn
Doberjohn merged commit c90b65c into main Nov 18, 2026
14 checks passed
@Doberjohn
Doberjohn deleted the @Doberjohn/fab-reduce-motion branch November 18, 2026 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant