Repository navigation
fix(fab): honour reduceMotion="off" over the device setting - #5231
Merged
Merged
Conversation
FAB, FAB.Extended and FAB.Menu called withSpring without a reduceMotion config, so Reanimated followed the device setting and snapped them even when PaperProvider allowed motion. Pass ReduceMotion.Never when Paper's preference allows motion, as Checkbox and Switch do.
|
Found potential problems with the pull request:
|
This comment has been minimized.
This comment has been minimized.
Apex Sentinel · ✅ Approve · review of
|
| Command | What it does |
|---|---|
@apex-sentinel-staging note <context> |
Adds context; Sentinel re-checks the cited code |
@apex-sentinel-staging pivot <why> |
Says the finding is wrong; Sentinel re-checks the cited code |
@apex-sentinel-staging like |
Marks the finding as useful |
@apex-sentinel-staging dislike <why> |
Marks it as not useful, so it is not raised again |
On this conversation, comment @apex-sentinel-staging review to run a full review once again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
<PaperProvider reduceMotion="off">should keep animations on when the device asks for less motion. Checkbox and Switch pass an explicit ReanimatedreduceMotion; FAB, FAB.Extended and FAB.Menu didn't, so Reanimated followed the device and snapped them. Their springs now passReduceMotion.Neverwhen Paper allows motion.Related issue
None.
Screenshots / Videos
None: only visible with the device setting on and
reduceMotion="off".Test plan
yarn testcovers the spring configs.reduceMotion="off": the FAB animates; onmainit snaps.