Skip to content

fix(menu): scale the menu in on every open, not only the first - #5232

Merged
Doberjohn merged 3 commits into
mainfrom
@Doberjohn/menu-reopen-scale
Nov 18, 2026
Merged

Doberjohn merged 3 commits into
mainfrom
@Doberjohn/menu-reopen-scale

Conversation

@Doberjohn

@Doberjohn Doberjohn commented Nov 17, 2026 •

Copy link
Copy Markdown
Collaborator

Motivation

A Menu scales in only on its first open. Close it and open it again with the same anchor, and it just fades in at full size. The hide left the scale values at the measured size, so the next open's withTiming started at its target and Reanimated skipped it. They now go back to 0 when the hide finishes.

Related issue

None filed. Found while sampling the Menu's animated styles in Jest.

Screenshots / Videos

Before and after on iOS (open, close, open again):

Before:

menu-ios-before-main.mp4

After:

menu-ios-after-fix-v2.mp4

Test plan

In the example's Menu screen, checked on iOS 27.2, Android 13 and web:

  1. Open, close and open again: the second open grows from the anchor like the first.
  2. Close and reopen before the fade-out ends: it fades back in, with no jump.

After a hide, scaleX and scaleY kept the measured size. A reopen with
the same anchor and size then started withTiming at its target, so
Reanimated skipped it and the menu only faded in. Reset both to 0 when
the hide animation finishes, so each open starts from zero like the
first one.
@apex-sentinel-staging

This comment has been minimized.

@apex-sentinel-staging

Copy link
Copy Markdown

Apex Sentinel · ✅ Approve · review of 008cdd9

Since the review of 82c2600: 0 new · 0 still open · 0 no longer raised

No open findings.

1 finding below minor hidden (user_settings.min_severity).

Reviewed with this repository's own Sentinel configuration (c90b65c6b8bc).

💬 Talking to Sentinel

In a finding's thread, reply with:

Command What it does
@apex-sentinel-staging note <context> Adds context; Sentinel re-checks the cited code
@apex-sentinel-staging pivot <why> Says the finding is wrong; Sentinel re-checks the cited code
@apex-sentinel-staging like Marks the finding as useful
@apex-sentinel-staging dislike <why> Marks it as not useful, so it is not raised again

On this conversation, comment @apex-sentinel-staging review to run a full review once again.

@Doberjohn
Doberjohn merged commit 4c4bd8f into main Nov 18, 2026
14 checks passed
@Doberjohn
Doberjohn deleted the @Doberjohn/menu-reopen-scale branch November 18, 2026 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant