Repository navigation
Conversation
The 16 components that multiplied durations by `theme.animation.scale` now read `useReduceMotion()`, which is exported with the `ReduceMotionPreference` type. A component's `theme` prop can no longer turn animations back on under reduce motion, `'auto'` starts from the device setting at launch, and an OS setting change no longer replays Banner, CrossFadeIcon or ActivityIndicator animations. BREAKING CHANGE: `theme.animation.scale` is removed; pass `reduceMotion="on"` to `PaperProvider` to turn animations off, and read the preference with `useReduceMotion()`.
|
Found potential problems with the pull request:
|
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Apex Sentinel: 2 new findings on 38d67ab. The verdict and the full list are in the summary comment.
Apex Sentinel · ✅ Approve · review of
|
| Command | What it does |
|---|---|
@apex-sentinel-staging note <context> |
Adds context; Sentinel re-checks the cited code |
@apex-sentinel-staging pivot <why> |
Says the finding is wrong; Sentinel re-checks the cited code |
@apex-sentinel-staging like |
Marks the finding as useful |
@apex-sentinel-staging dislike <why> |
Marks it as not useful, so it is not raised again |
On this conversation, comment @apex-sentinel-staging review to run a full review once again.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
theme.animation.scalereached 16 components, while Checkbox, Switch, FAB and others read onlyuseReduceMotion(), and a componentthemeprop could undoreduceMotion="on". This removestheme.animation: the 16 readuseReduceMotion(), now exported withReduceMotionPreference.'auto'starts from the launch-time device setting. The guides are updated.Related issue
Follow-up to #4924.
Screenshots / Videos
None: nothing changes with default settings.
Test plan
yarn typecheck,yarn lint,yarn test.reduceMotion="on".'auto'reads it on the first render.