Repository navigation
Conversation
# Conflicts: # apps/tester-federation-v2/package.json # pnpm-lock.yaml
…ures-to-mf2-testing-app
…es-to-mf2-testing-app
|
|
@MrMuzyk is attempting to deploy a commit to the Callstack Team on Vercel. A member of the Team first needs to authorize it. |
|
Still in draft. Waits for #1514 |
Apex Sentinel · ✅ ApproveSince the last review: 0 new · 0 still open · 1 no longer raised No open findings. Not in the reviewers' prompt (1 file)
6 findings below 💬 Talking to SentinelIn a finding's thread, reply with:
On this conversation, comment Earlier reviewsReview of
|
| Where | Finding |
|---|---|
apps/tester-expo/app/symbolication.tsx:11 |
Failed symbolication leaves the button reading "Symbolicated" and disabled |
Not in the reviewers' prompt (1 file)
pnpm-lock.yaml: generated or a lockfile, so its lines were left out
3 findings below minor hidden (user_settings.min_severity).
1 new finding away from what changed since 46a6035 not shown. Comment @apex-sentinel-staging review for a full review.
Reviewed with this repository's own Sentinel configuration (6e72ac0df314).
Review of 46a60350 · 16.11.2026 15:37 UTC
Apex Sentinel · ✅ Approve
2 finding(s): 2 minor.
🟡 Minor (2)
| Where | Finding |
|---|---|
apps/tester-expo/app/symbolication.tsx:10 |
Failed symbolication leaves the button reading "Symbolicated" and disabled |
.github/workflows/e2e-expo.yml:200 |
e2e-expo iOS job boots a simulator before prebuild; simctl create can die on a stale e2e device |
Not in the reviewers' prompt (1 file)
pnpm-lock.yaml: generated or a lockfile, so its lines were left out
3 findings below minor hidden (user_settings.min_severity).
Reviewed with this repository's own Sentinel configuration (6e72ac0df314).
There was a problem hiding this comment.
Apex Sentinel: 2 new findings on 46a6035. The verdict and the full list are in the summary comment.
There was a problem hiding this comment.
Apex Sentinel: 1 finding moved to a new line on a4604d9. The verdict and the full list are in the summary comment.
Summary
Covers
apps/tester-expowith e2e tests, so an Expo change no longer means booting the Expo apps by hand. Until now PRs only typechecked it. A second lane,e2e-expo.yml, runs it on the same tooling and rules as the MF2 lane: aFEATURES.tsregistry driving Home, one screen and one spec per feature, every spec owning one distinct way to fail. Nine specs: Expo native module, image, density image, font, local async chunk, Expo-built remote (ExpoWidget), plain Re.Pack remote (OrdinaryWidget), Fast Refresh, symbolication.tester-expo-widget(8082) and MF2'sstart:expo-host-widget(8083). The workflow starts and warms all three;adb reversegets a third port.mainand dispatch — same as the MF2 lane.expo prebuildgenerates the native folders first, since they are not in git.fast-refresheditscomponents/FastRefreshLeaf.tsxon disk and checks that the new text shows up while the counter keeps its value (no full reload). The file is restored infinally.symbolicationsends its own error through RN'sparseErrorStack+symbolicateStackTraceand checks that the first frame maps back toSymbolicationProbe.tsx:<line>; the line is read from the file, never hardcoded.babel.config.cjssetsdisableDeepImportWarnings: true. RN 0.88 turns the first warning into a toast that steals e2e taps, and babel-preset-expo's deep-import lint fires on the linkedpackages/repackand on the probe's RN imports. No LogBox filter, so a new warning still shows.e2e.ymltriggers change from apathsallow-list topaths-ignore: website/**, **/*.md, same as the new workflow. Root files likepnpm-workspace.yamlchange what the apps run, and the allow-list skipped them.agent_context/e2e-oct2026/design.mdis split into shared rules, the MF2 lane and the Expo lane; the Expo part has the coverage table, the break-once record and the traps.Test plan
Demo video:
tester-expo.mp4
CI: https://github.com/MrMuzyk/repack/actions/runs/44058977106 — Android + iOS, artifacts carry junit, screenshots, logcat and dev-server logs on failure.
Locally (boot an emulator/simulator and install the app first —
pnpm repack:android/pnpm repack:iosinapps/tester-expo; Node ≥ 24.8):The Debug build loads JS from all three servers, so they must stay up. Warm them on a fresh start (the
index.bundleandmf-manifest.jsonURLs the workflow uses), otherwise the cold compile eats the boot anchor. After apnpm installthat changes the lockfile, restart them — a running server keeps the old package paths.9/9 green locally on Android (API 35 emulator) and iOS (iPhone 17 Pro simulator). Each spec was broken once on purpose and went red at its own assert — the break-once table in
design.mdlists what was broken.