Repository navigation
Conversation
Malformed time strings were replaced with the current timestamp. Reject them with ValidationError, and still default time when it is omitted. Signed-off-by: eisen0419 <usetoken0419@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DateParser.parsefell back tonew Date()whenDate.parse()returnedInvalid Date, andshouldParseskipped empty string values before they reached the parser. As a result,HTTP.toEventreplaced malformed or emptyce-time/timevalues with the current UTC timestamp instead of failing validation (andHTTP.isEventreturnedtrue).Changes
timestrings inDateParser.parseagainst RFC 3339date-time(including calendar month/day bounds and UTC/numeric offsets) and throwValidationError("invalid time, must be RFC 3339")on malformed or non-string inputs instead of substitutingnew Date().ce-time/timeattributes (including"") throughDateParserinsrc/message/http/index.ts, while keeping omitted,undefined, and JSONnullvalues on the existing default path per the CloudEvents JSON format spec.??) inCloudEventconstruction so falsy values such as"",0, orfalseare not silently defaulted to the current timestamp before schema validation.test/integration/time_validation_test.ts.Fixes #386