Skip to content

Remove commented-out deploy job from CI workflow - #652

Merged
slachiewicz merged 1 commit into
masterfrom
agent/sweep-modello-workflow-comment
Nov 18, 2026
Merged

slachiewicz merged 1 commit into
masterfrom
agent/sweep-modello-workflow-comment

Conversation

@slachiewicz

Copy link
Copy Markdown
Member

The deploy job in .github/workflows/maven.yml has been commented out for a
long time. Dead configuration in the workflow makes it unclear how releases
are actually published, so remove it.

Area: CI setup only; no build inputs, sources or tests change.

Changes:

  • Deleted the commented-out deploy job block (name, needs, shared
    maven-deploy.yml reference and secrets: inherit) plus its extra blank
    line at the end of the file.

Verification:

  • actionlint .github/workflows/maven.yml - exit 0, no findings
  • JAVA_HOME=/Library/Java/JavaVirtualMachines/zulu-21.jdk/Contents/Home mvn -B -o spotless:apply - BUILD SUCCESS, no reformatting
  • JAVA_HOME=/Library/Java/JavaVirtualMachines/zulu-21.jdk/Contents/Home mvn -B -o spotless:check - BUILD SUCCESS
  • JAVA_HOME=/Library/Java/JavaVirtualMachines/zulu-21.jdk/Contents/Home mvn -B -o test - BUILD SUCCESS, 178 tests run, 0 failures/errors/skips

The block referenced the shared maven-deploy workflow but has been commented
out for a long time; keeping dead configuration in the workflow invites
confusion about how releases are published.

@gnodet-bot gnodet-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Removing dead commented-out YAML has no runtime impact — this is a clean housekeeping change.

This review was generated by an AI agent, Hermès on behalf of @gnodet.

@slachiewicz
slachiewicz merged commit cc0772e into master Nov 18, 2026
11 checks passed
@slachiewicz
slachiewicz deleted the agent/sweep-modello-workflow-comment branch November 18, 2026 22:24
@slachiewicz slachiewicz added the build Pull requests that change the build process label Nov 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Pull requests that change the build process

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants