Repository navigation
Remove commented-out deploy job from CI workflow - #652
Merged
Merged
Conversation
The block referenced the shared maven-deploy workflow but has been commented out for a long time; keeping dead configuration in the workflow invites confusion about how releases are published.
gnodet-bot
approved these changes
Nov 18, 2026
gnodet-bot
left a comment
There was a problem hiding this comment.
LGTM. Removing dead commented-out YAML has no runtime impact — this is a clean housekeeping change.
This review was generated by an AI agent, Hermès on behalf of @gnodet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The deploy job in
.github/workflows/maven.ymlhas been commented out for along time. Dead configuration in the workflow makes it unclear how releases
are actually published, so remove it.
Area: CI setup only; no build inputs, sources or tests change.
Changes:
deployjob block (name, needs, sharedmaven-deploy.ymlreference andsecrets: inherit) plus its extra blankline at the end of the file.
Verification:
actionlint .github/workflows/maven.yml- exit 0, no findingsJAVA_HOME=/Library/Java/JavaVirtualMachines/zulu-21.jdk/Contents/Home mvn -B -o spotless:apply- BUILD SUCCESS, no reformattingJAVA_HOME=/Library/Java/JavaVirtualMachines/zulu-21.jdk/Contents/Home mvn -B -o spotless:check- BUILD SUCCESSJAVA_HOME=/Library/Java/JavaVirtualMachines/zulu-21.jdk/Contents/Home mvn -B -o test- BUILD SUCCESS, 178 tests run, 0 failures/errors/skips