Repository navigation
Conversation
TestAutobahn gave the wstest container 5s to accept a handshake after docker run. Since the daily jobs moved to ubuntu-26.04 (Docker 29.4.2), the first container start on a fresh runner takes 2.8s to 12s, then wstest needs about 1s more to listen. On 24.04 (Docker 28.0.4) the first start took under 0.5s. The test failed in 13 of 27 daily test jobs since 2026-10-30. waitWS now allows a minute, sleeps 100ms between dials instead of dialing in a busy loop, and returns the last dial error.
Killing the docker run client leaves the container running, so each TestAutobahn run left a wstest container behind. closeFn now removes the container by name. wstestServer now returns once the server accepts handshakes, and stops waiting when docker run exits, so a server that fails to start fails the test right away. That lets the wait allow 5 minutes for a slow start.
The image is pulled before docker run, so the wait covers only the container start and wstest's startup, which took at most 13.5s on the runners measured. 2 minutes is enough for that. docker run exiting now cancels the wait's context with the exit error as its cause, so waitWS needs no separate channel.
mafredri
marked this pull request as ready for review
November 14, 2026 16:45
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestAutobahngave the wstest container 5s afterdocker runto accept a WebSocket handshake. On GitHub's ubuntu-26.04 runners that is often not enough, and the dailytestjobs fail withautobahn_test.go:72: context deadline exceeded(#598). Since the daily jobs moved to 26.04 on 2026-10-30, 13 of 27 failed this way.The image is already pulled when the wait starts. The time goes to the first container start after
docker pull: on 26.04 (Docker 29.4.2 with the containerd image store), that start took about 2.8s on AMD EPYC 7763 VMs and 2.9s to 7.3s on EPYC 9V45, EPYC 9V74 and Xeon 8573C VMs. wstest starts listening about 1.1s later. Under the fullci/test.shload, the server took 2.4s to 13.5s to accept a handshake. On 24.04 (Docker 28.0.4), the same start took under 0.5s on every VM type. The daily failures follow the VM type: 0 of 11 jobs on EPYC 7763 failed, and 13 of 15 on the other types.wstestServernow returns once the server accepts a handshake. It dials every 100ms instead of in a busy loop, fails as soon asdocker runexits, and gives up after 2 minutes.Killing the
docker runclient does not stop the container, so each run left a wstest container running.closeFnnow removes the container by name.Refs #598
Verification
AUTOBAHN=1 make teston ubuntu-26.04 with earlier versions of this branch: 43599366425 (5 minute limit, same container removal), 8 of 8 passed (5 on the slower VM types), with no container left afterwards. 43595298461 (1 minute limit), 6 of 6 passed. Master's test in the same run passed 5 of 6 and failed once with the 5s error.AUTOBAHN=fastpasses and leaves no container. With an invalid wstest mode, the test fails after 2.2s withwstest exited: exit status 1.make lintpassed.Decision log
docker runexit, which ends the wait right away.