Repository navigation
Conversation
Add authorization-injector-core, a wasi:http/client middleware that adds an `authorization` header to outgoing requests. The value is chosen by the request's origin, from `wasi:config/store`. It is only added for methods the `methods` config store allows. Requests that already have an authorization header pass through unchanged. An invalid config fails every request, so a typo gets noticed instead of being ignored. The headers on a wasi:http 0.3 request can't be changed, so the core clones them, sets the authorization and builds a new request. The new request keeps the original's method, target, options, body and trailers, and its transmission result is passed back to the original request. The caller gave up ownership of the request, so it never sees the authorization value. Add authorization-injector, which composes the core with authorization-injector-method-config. That config allows every standard method except TRACE. In the test harness, add `Harness::named_config` to provide `wasi:config/store` under a named import. Add `host_request_with` to build host requests with headers and a body. Signed-off-by: Scott Andrews <scott@andrews.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add authorization-injector-core, a wasi:http/client middleware that adds an
authorizationheader to outgoing requests. The value is chosen by the request's origin, fromwasi:config/store. It is only added for methods themethodsconfig store allows. Requests that already have an authorization header pass through unchanged. An invalid config fails every request, so a typo gets noticed instead of being ignored.The headers on a wasi:http 0.3 request can't be changed, so the core clones them, sets the authorization and builds a new request. The new request keeps the original's method, target, options, body and trailers, and its transmission result is passed back to the original request. The caller gave up ownership of the request, so it never sees the authorization value.
Add authorization-injector, which composes the core with authorization-injector-method-config. That config allows every standard method except TRACE.
In the test harness, add
Harness::named_configto providewasi:config/storeunder a named import. Addhost_request_withto build host requests with headers and a body.