Repository navigation
Add test for #8789 - #9022
Merged
Merged
Add test for #8789#9022
Conversation
dmcppcheck
reviewed
Nov 13, 2026
dmcppcheck
left a comment
Contributor
There was a problem hiding this comment.
AI review
I found no problems. The PR only adds a regression test for #8789 to TestTokenizer::simplifyNamespaceStd. The test checks that, after using namespace std;, a call to search with 3 arguments is left unqualified, while a call with 4 arguments becomes std::search. That matches the 4-argument std::search entry in cfg/std.cfg and what the cppcheck binary does now.
Testing
- Built
cppcheckandtestrunnerinpr/withmake -j8. ./testrunner TestTokenizerran 392 tests: 0 failed, 3 todos.- I ran the PR's binary on the code from the test with
cppcheck --debug-normal a.cpp. The output matches what the test expects:3: search ( p , q , p ) ; 4: std :: search ( p , q , p , q ) ; - I did not build
base/or run it, because the PR changes no library code.
Automated review of bcab7ac by Claude. The pull request was built and tested locally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.